Repository navigation
fix(api): report rows wider than the header instead of truncating them (#82) - #88
Merged
Merged
Conversation
#82) Both loaders iterated only over the header's columns, so a row with more cells than the header lost the extra values without trace. A row with non-empty cells beyond the header is now a row error (counted in failedRows, listed in rowErrors with the first lost value) and is not imported. Empty trailing cells, as left by a trailing comma, are still accepted. Shared check: csv_parse.extra_cells. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019YPoXzBSj89ZHgw7nfTmbB
amar-python
added
bug
Claude
Brings in #87, #90 and #86. No conflicts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019YPoXzBSj89ZHgw7nfTmbB
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #82. Part of ART Milestone 1 (BR-34; ART data-preservation constraint).
Change
dynamic_loader.py,te_loader.py) iterated only over the header's columns, so cells beyond the header width were silently dropped.failedRows.rowErrorswithcolumn: "(beyond header)", the first lost value, and a reason naming both widths.csv_parse.extra_cells(), used by both loaders.The response shape is unchanged, so the frontend's existing row-error UI shows these rows as it shows cast failures.
Evidence
Local PostgreSQL 16, replicating the CI integration job:
scripts/test_report.py --strictevals/runner.py --tiers p,i,s,epytest tests/test_ragged_rows.pyscripts/lint.shcsv_parse.py:60, which is also onmainThis branch is independent of #86 and #87.
Generated by Claude Code