Repository navigation
fix(frontend): neutralise spreadsheet formula injection in CSV export (#83) - #86
Merged
Merged
Conversation
…#83) escapeCsv now prefixes values starting with = + - @ tab or CR with a quote (OWASP CSV injection), leaving plain signed numbers alone, and quotes values containing CR. Error and audit report exports carry user-supplied cells, so a payload like =HYPERLINK(...) no longer runs when the export is opened in Excel. XLSX output is unaffected: json_to_sheet stores strings as text cells, not formulas. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019YPoXzBSj89ZHgw7nfTmbB
amar-python
added
art
Claude
amar-python
pushed a commit
that referenced
this pull request
Oct 26, 2026
Brings in #87, #90 and #86. No conflicts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019YPoXzBSj89ZHgw7nfTmbB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #83. Part of ART Milestone 1 (BR-35, export part).
Change
escapeCsvincsv-table-hub-main/src/lib/export.ts:=,+,-,@, tab or CR with', per OWASP CSV-injection guidance.-5and+3.2untouched, so numeric report values keep their meaning.XLSX export is unaffected. SheetJS
json_to_sheetwrites strings as text cells, never formulas.Evidence
npx vitest run: 8 files, 107 passed (102 before, plus 5 new).npx tsc --noEmit: exit 0.main, so nothing new.Generated by Claude Code