Repository navigation
feat(frontend): review screen for stored uploads (M4b, #108) - #143
Merged
Merged
Conversation
A Review link on each migrated file opens /review/{uploadId}. It pages
through every stored row (100 a page) with column types, marks invalid
cells and edited cells (title shows the reason or the original), and
lets reviewers and tenant admins exclude or include a row and edit a
cell, each with a required reason. A history dialog lists a row's
decisions and edits. Other roles can view only.
scripts/e2e/m4-review.js drives it in Chromium against a running API
and frontend: 8 of 8 checks passed. VCRM: BR-25 and BR-26 verified.
vitest 147 passed (4 new); tsc 0; production build OK.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019YPoXzBSj89ZHgw7nfTmbB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #108. This is part M4b of ART Milestone 4, the review screen. It's stacked on #142, the review API. Merge #142 first, and this PR's base then moves to
main.What it does
/review/{uploadId}.scripts/e2e/m4-review.jsis a repeatable browser check. It needsE2E_TENANT,E2E_USERandE2E_PASSWORD, and a running API and frontend.Found by the end-to-end check, fixed in #142
The browser's preflight for
PUTwas refused, because CORS allowed only GET, POST and DELETE. The unit tests mock the network, so they couldn't catch it. #142 now allows PUT and has a test that fails without it.Verification
review-table.test.tsx): rows, validation, edits and decision shown; a reviewer excludes with a required reason; a tenant admin edits a cell; an uploader can view but not changetsc --noEmitnode-server)scripts/e2e/m4-review.js)I broke the component to check that the tests catch it. With Save enabled while the reason is empty, the exclude test failed (1 failed, 3 passed).
VCRM: BR-25 and BR-26 are now ✅ (API plus e2e), joining BR-27 from #142. The headline is now 23 of 38.
Generated by Claude Code