Skip to content

ART M4: review — full paging, include/exclude, versioned cell edits (BR-25, BR-26, BR-27) #108

Open

Description

@amar-python

Plan: docs/art/milestone-0-assessment.md §5b. Approved 26 Oct.

  • Page through the full dataset, not just a preview.
  • Mark rows to include or exclude.
  • Cell edits are stored as versions (decision D2), with the original kept.

Verified by: API tests and e2e tests.


Generated by Claude Code

Activity

  1. added this to the ART extension milestone on Oct 26, 2026
  2. amar-python commented on Oct 28, 2026

    @amar-python
    OwnerAuthor

    Decisions by the product owner, 28 Oct 2026

    1. Review is recorded now and applied in M6. M4 records include and exclude decisions and cell edits against the stored upload (M3's source_rows), and everyone in the tenant can see them. The table imported at upload time doesn't change. M6's approval and staged import will import the reviewed version.
    2. Who reviews: reviewer and tenant_admin may decide rows and edit cells. Everyone with read_rows can view.
    3. A reason is required for every decision and edit. The API refuses an empty one.

    Parts

    • M4a (API and database):
      • Insert-only row_decisions and cell_edits, where the latest entry wins and the history is kept.
      • The column types each upload used are stored, so every row can be validated, not only the first 200 failures.
      • GET /api/csv/uploads/{id}/rows pages through every row, giving original and current values, validation errors and the row's decision.
      • Endpoints to record a decision and a cell edit, plus a row's history. Each change is also written to the audit log, with before and after values.
    • M4b (frontend): a review screen that pages through every row, with include and exclude, cell edits and the history.

    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    artART framework extension work

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions