Repository navigation
docs: describe add_picture's sizing, adjustments, crop and effects - #455
Merged
Merged
Conversation
The API reference listed no add_picture entry. Describe its size arguments, the image adjustments and border, crop, the shadow, glow, soft edge and reflection effects and the room they take, and the error codes values Hancom does not draw are refused with. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
리뷰 결과: 병합합니다. 문서의 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
바뀐 점
docs/api_reference.md의HwpxDocument콘텐츠 생성 헬퍼에add_picture항목이 없었다. #445·#446·#447·#448·#451에서 더한 인자를 포함해 설명을 더한다.width·height(HWPUNIT) 또는width_mm·height_mm. 너비를 빼면 14400이다. 높이를 빼면 PNG는 가로세로 비율을, 다른 형식은 너비와 같은 높이를 쓴다.align은 그림을 둔 단락의 정렬이다.brightness·contrast(-100100),255).effect(REAL_PIC·GRAY_SCALE·BLACK_WHITE),alpha(0line_color·line_width.crop(네 변, HWPUNIT, 축척 유지).shadow·glow·soft_edge·reflection. 바깥 효과만큼 자리를 차지한다.shape-picture-image-value·-border-value·-crop-value·-effect-value·style-color-invalid.HwpxOxmlParagraph.add_picture도 같은 인자를 받는다. 뒤집기·회전은 미지원이다.글만 더하고 코드 블록은 넣지 않았다(예제 원장은 그대로).
테스트
inspect.signature(HwpxDocument.add_picture)와 대조했다.tests/test_documentation_code_fences.py,tests/test_contract_docs_sync.py가 통과한다. 남는 실패 하나(설치된 wheel 예제 실행)는 이 PC 환경의 기존 실패다.🤖 Generated with Claude Code