Repository navigation
fix(picture): write a picture's border before its image rectangle - #446
Merged
Merged
Conversation
The schema's PictureType has hp:lineShape right before hp:imgRect, and so do Hancom's pictures in either of their two child orders; the border went after hc:img, where none has it (Hancom drew it and saved it back in its place all the same). A bad line_width is now refused without a line_color too, not dropped quietly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…mits Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
리뷰 결과: 병합합니다.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
바뀐 점
#445(그림 효과·테두리)의 후속이다.
add_picture가 쓰는 테두리hp:lineShape를hp:imgRect바로 앞에 둔다. 스키마의PictureType이 그 순서이고, 한/글 그림도 두 가지 자식 순서(hc:img가 앞인 것, 뒤인 것) 모두lineShape바로 뒤에imgRect가 온다. 전에는hc:img뒤(… imgDim, img, lineShape, effects)에 두었는데, 그런 순서는 한/글 그림에 없다. 한/글은 두 자리 모두 같게 그리고, 저장할 때 자기 순서로 다시 쓴다.line_width를line_color없이 줘도 검사한다. 전에는 색이 없으면 잘못된 굵기(예: -1)를 말없이 버렸다. 이제shape-picture-border-value로 거부한다. 문단 수준과 문서 수준 둘 다 같다.add_picture()인자로 줄 수 있고, 그림자·반사 같은 효과와 자르기·회전은 아직 지원하지 않는다고 적는다. 예제 원장의 두 README 해시(manualSha256)도 바꾼다.테스트
tests/test_picture_adjustments.py:imgRect바로 앞에 있는지 본다(전에는img바로 뒤를 봤다).line_width=-1을 색 없이 주면 거부되고, 문단과 이진 항목이 늘지 않는다.🤖 Generated with Claude Code