Repository navigation
Conversation
Raise the Undici minimum to 6.28.1 and regenerate the package lockfile at 6.29.0. Prepare only the HTTP-client patch release; leave consumer upgrades and artifact behavior to their own layers. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused dependency and release metadata changes are internally consistent and preserve supported runtime compatibility.
Review effort: Balanced
Findings: None
What changed in this PR
Prepares the dependency-only @actions/http-client 4.0.2 patch release.
Changes:
- Raises the Undici minimum to 6.28.1 and locks 6.29.0.
- Synchronizes package and lockfile versions at 4.0.2.
- Adds release notes.
| File | Description |
|---|---|
packages/http-client/RELEASES.md |
Documents the dependency update. |
packages/http-client/package.json |
Updates package version and Undici range. |
packages/http-client/package-lock.json |
Synchronizes metadata and Undici resolution. |
Files not reviewed (1)
- packages/http-client/package-lock.json: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Layer [1/4] of the approved four-layer plan: prepare a dependency-only
@actions/http-client4.0.2 patch release.^6.23.0to^6.28.1, the first patched v6 floor for the known advisories, and regenerate the package lockfile with npm, resolving published 6.29.0.packages/http-client/{package.json,package-lock.json,RELEASES.md}. Preserve existing overrides. No consumer manifests/locks, new overrides, source/API changes, artifact retry changes, or artifact release metadata.Ordering and publication
This is a standalone cross-fork draft against
actions/toolkit:main, not a native stack. The user approved preparing the new drafts against upstream main despite inherited lower-layer diffs remaining visible in later layers until earlier PRs merge.Review/merge order is [1/4] HTTP-client dependency release → [2/4] consumer minimums and audit fixes → [3/4] artifact retry → [4/4] artifact 6.3.0 metadata. The original #2498 is preserved as layer 3; its review threads are untouched. Layer 2 and layer 4 links will be added when available.
4.0.2 is planned and still unpublished: the npm registry lists latest 4.0.1 and no 4.0.2 at preparation time. Maintainers must merge this lower layer and publish HTTP-client 4.0.2 before consumer upgrades to
^4.0.2can be installed and their per-package lockfiles validated. No npm publication is performed or authorized here.Validation and compatibility
npm install --prefix packages/http-client --package-lock-only --ignore-scripts --no-fundandnpm audit --prefix packages/http-client --package-lock-only --audit-level=moderate: 0 vulnerabilities.git diff --check, and strict three-file isolation.3af00a0522a4c28679a97918f53f3329c506aaeb. Reused its recorded Node 20.20.2 / 24.21.0 HTTP-client builds and 5 suites / 75 tests on each runtime, including proxy routing/bypass, authentication/encoded credentials, and the UndiciProxyAgentdispatcher. No test reruns solely for copying the unchanged, verified slice.Baseline CI limitation
Repository-wide audit may still fail on unchanged packages until layer 2 supplies the other audit fixes. The validated source's audit run failed in unchanged
@actions/core, while HTTP-client reported zero vulnerabilities. Those fixes intentionally remain outside layer 1; this is not an all-CI-green claim.The superseded drafts #2515/#2516/#2517 remain closed; they are not active dependencies. No old branches, review replies/resolutions, merge/auto-merge, npm publication, or primary-checkout changes.