Repository navigation
Conversation
Separate brace-expansion and markdown-it audit fixes from the artifact retry change. Refresh only undici lock resolutions using published 6.29.0 without consumer overrides or unpublished HTTP-client minimums. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This was referenced Oct 1, 2026
Refresh only the http-client undici lock resolution to published 6.29.0. Keep http-client 4.0.1 and its ^6.23.0 dependency floor unchanged; planned 4.0.2 release changes remain separate. Verify npm install, npm run bootstrap, root production audit, and npm run audit-all: all nine audited packages have zero vulnerabilities. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This was referenced Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Separates npm-audit maintenance from the retry and artifact 6.3.0 release changes in #2498, as requested in the review, so dependency changes can be reverted independently.
Only seven files change:
brace-expansion@^2→^2.1.7,brace-expansion@^5→^5.0.12, andmarkdown-it→^14.3.1(lock resolves 14.3.2).brace-expansion→^5.0.12.npm update undicirefreshes artifact/core/glob/tool-cache/HTTP-client locks to already-published 6.29.0, satisfying their existing ranges.No undici overrides, HTTP-client dependency-floor changes, package-version changes, release metadata, source code, or test changes. HTTP-client remains 4.0.1 with
undici ^6.23.0; only its locked undici resolution changes. HTTP-client's version/floor/release work remains exclusively in #2515.Locks were regenerated with npm. Structural comparison against main confirms that only brace-expansion, markdown-it, and undici entries changed; unrelated packages and HTTP-client package resolutions remain untouched.
Audit-first prerequisite
The initial Audit failure was at unchanged HTTP-client 4.0.1, before dependent package audits could run. Conversely, #2515 failed at unchanged core. Ordering those original diffs alone would still require bypassing a baseline failure.
The minimal HTTP-client lockfile-only follow-up removes that cycle: this PR now passes the complete Audit workflow locally and can be the audit-first prerequisite. No HTTP-client publication is needed for these published lock resolutions. After this PR lands, #2515 can be rebased onto the audit-patched main while retaining its independent dependency-floor/version/release changes. No merge or publication is performed here.
Audit evidence
Full package audits, including development dependencies:
Exact undici advisory evidence returned by the baseline audits:
<6.27.0<6.27.0<6.27.0<6.28.0<6.28.0<6.28.0<6.27.0>=6.25.0 <6.28.1<6.28.1>=6.7.0 <6.28.1Artifact's actual locked 6.28.0 has three advisories; core/glob/HTTP-client have nine, and tool-cache has ten. Each baseline undici dependency is reported as high severity. All five final package audits have zero vulnerabilities at 6.29.0.
Brace-expansion baseline advisories: GHSA-3jxr-9vmj-r5cp, GHSA-mh99-v99m-4gvg, GHSA-rgw5-rvv9-x895, GHSA-q2hr-2g5m-vwhr, GHSA-qhr7-859c-m2p7, and GHSA-6j4f-fj2g-mc7p. Markdown-it: GHSA-253c-mchw-3w2r, affecting
<14.3.1.Full workflow validation
Ran the actual CI sequence, without replacing package installs with lock-only audits:
All commands exit 0. The root production audit reports zero vulnerabilities.
npm run audit-allexecutes each existingnpm install && npm audit --json --audit-level=moderate > audit.jsonscript: all nine projects (artifact, cache, core, exec, github, glob, HTTP-client, io, tool-cache) finish with zero vulnerabilities, including their development dependencies. Cache/github were already patched; no additional locks or unrelated entries needed updating. After these actual install semantics, the follow-up diff still contains only HTTP-client's one undici lock entry.npm test -- --runInBand --forceExit packages/artifact packages/core packages/glob packages/tool-cache packages/http-client: 31 suites, 463 tests pass, using the repository CI's force-exit convention.Related work and deferred minimums
^4.0.2minimums remain deferred until publication. This audit-first slice does not require an unpublished registry version.After HTTP-client 4.0.2 is published, artifact/core/tool-cache can raise their direct minimums to
^4.0.2and regenerate their locks. Glob has no direct HTTP-client dependency:@actions/core ^3.0.0(locked 3.0.0) →@actions/http-client ^4.0.0(locked 4.0.0). Artifact also retains@actions/github 9.1.1→@actions/http-client ^3.0.2(locked 3.0.2), plus GitHub's directundici ^6.23.0. A direct HTTP-client 4.x minimum alone does not raise those transitive floors; the targeted lock refresh already resolves their installed undici paths without an extra package release or override.