Repository navigation
Invert controller axes in wheel mode and make speed adjustable - #421
Merged
Merged
Conversation
Roozki
previously approved these changes
Aug 7, 2022
Roozki
left a comment
Roozki
left a comment
Contributor
There was a problem hiding this comment.
No typos found, logic looks good to me
Roozki
approved these changes
Aug 8, 2022
ihsan314
added a commit
to ihsan314/Snowflake
that referenced
this pull request
Aug 10, 2022
…nowbots#421) * Swap X & Y axes on left joystick in wheel mode * Move setup call and use ROS_DEBUG when debug is set to true * Change speed of rover via arrowbuttons * Format ProController.cpp Co-authored-by: TateKolton <tatekolton@gmail.com>
ihsan314
added a commit
to ihsan314/Snowflake
that referenced
this pull request
Aug 14, 2022
…nowbots#421) * Swap X & Y axes on left joystick in wheel mode * Move setup call and use ROS_DEBUG when debug is set to true * Change speed of rover via arrowbuttons * Format ProController.cpp Co-authored-by: TateKolton <tatekolton@gmail.com>
ihsan314
added a commit
to ihsan314/Snowflake
that referenced
this pull request
Aug 15, 2022
…nowbots#421) * Swap X & Y axes on left joystick in wheel mode * Move setup call and use ROS_DEBUG when debug is set to true * Change speed of rover via arrowbuttons * Format ProController.cpp Co-authored-by: TateKolton <tatekolton@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Initially moving the left joystick on the pro controller forward/backward would cause the rover to turn, and moving the joystick right/left would move the rover forward and backwards. That has been fixed.
Additionally the rover did not have an adjustable speed at runtime. Now the rover does. One can press the up or down arrows to manipulate the speed.
Testing Done
Experimented on rover to verify correct behaviour.
Resolved Issues
resolves #408
Review Checklist
(Please check every item to indicate your code complies with it (by changing
[ ]->[x]). This will hopefully save both you and the reviewer(s) a lot of time!)It is the reviewers responsibility to also make sure every item here has been covered
.cppand.hfile should have a comment at the start of it. See files insrc/sample_packagefor examples..hfile) should have a javadoc style comment at the start of them. For examples, see the classes defined insrc/sample_packageTODO(or similar) statements should either be completed or associated with a github issueFeel free to make additions of things that we should be checking to this file if you think there's something missing!!!!