chore(main): release 3.3.0 - #51
Conversation
06f50c7 to
5cd84ad
Compare
|
Caution Review failedThe pull request is closed. ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
WalkthroughProject release bumped from 3.2.0 to 3.3.0: manifest root version updated, changelog entry for v3.3.0 added, and mix.exs Changes
Estimated Code Review Effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly Related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/release-please-manifest.json:
- Line 2: The release-please manifest value for the root package (the "." key in
.github/release-please-manifest.json) is out of sync and caused an incorrect
bump; update the manifest by setting the "." entry to "3.2.0" to match the
current project version, close or block this PR, then re-run Release Please so
it computes the next correct major bump (resulting in "4.0.0") and opens a new
PR.
In `@CHANGELOG.md`:
- Line 3: Duplicate CHANGELOG entry: update the new "## [2.0.0] (2026-02-23)"
section to remove duplication and correct its compare range; specifically,
replace the compare URL segment "v1.5.0...v2.0.0" with "v3.2.0...v2.0.0" (so the
heading "## [2.0.0]" matches the existing tag and shows the right diff), and
remove or merge the redundant 2.0.0 block to avoid two "## [2.0.0]" sections.
Then fix the manifest entry in .github/release-please-manifest.json to set the
correct lastRelease (pointing to v3.2.0) and re-run Release Please to regenerate
CHANGELOG.md so the duplicate and incorrect compare URL are resolved.
In `@mix.exs`:
- Line 4: The mix.exs `@version` value was incorrectly set to "2.0.0" causing a
semver/regression and Hex.pm publish conflict; update the `@version` assignment in
mix.exs from "2.0.0" to the correct release version "4.0.0" and also refresh the
Release Please manifest (.github/release-please-manifest.json) so future runs
compute the correct next version (ensure the manifest no longer pins the older
1.5.0 state); verify the change by running your project's version/check tasks to
confirm mix.exs's `@version` reads "4.0.0" before publishing.
| @@ -1,3 +1,3 @@ | |||
| { | |||
| ".": "1.5.0" | |||
| ".": "2.0.0" | |||
There was a problem hiding this comment.
Release-please manifest was out of sync with the actual project version — this is the root cause of the incorrect version bump.
The manifest records "1.5.0" as its prior version, but mix.exs was at "3.2.0" before this PR. Release-please computed 2.0.0 (major bump from 1.5.0 due to breaking changes), while the correct next version from 3.2.0 would be 4.0.0. The manifest and the project version drifted apart at some point in the past — all releases from 1.6.0 through 3.2.0 appear to have been cut without updating this manifest.
Recommended action: Block/close this PR, then:
- Update the manifest
"."to"3.2.0"to re-align with the actual codebase state. - Re-run Release Please so it generates a new PR targeting
4.0.0.
🐛 Proposed correction to the manifest
{
- ".": "2.0.0"
+ ".": "3.2.0"
}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/release-please-manifest.json at line 2, The release-please manifest
value for the root package (the "." key in .github/release-please-manifest.json)
is out of sync and caused an incorrect bump; update the manifest by setting the
"." entry to "3.2.0" to match the current project version, close or block this
PR, then re-run Release Please so it computes the next correct major bump
(resulting in "4.0.0") and opens a new PR.
| @@ -1,5 +1,55 @@ | |||
| # Changelog | |||
|
|
|||
| ## [2.0.0](https://github.com/straw-hat-team/commanded/compare/v1.5.0...v2.0.0) (2026-02-23) | |||
There was a problem hiding this comment.
Duplicate ## [2.0.0] version in the changelog, and the compare URL covers the wrong range.
Two separate ## [2.0.0] sections will exist in this file after merge: this new entry (2026-02-23) and the existing one at line 116 (2025-05-30). They have different compare URLs and dates for the same version tag, making the changelog internally inconsistent and the git tag v2.0.0 ambiguous.
Additionally, the compare URL v1.5.0...v2.0.0 spans the entire release history back to v1.5.0 and includes changes already documented in the 2.x and 3.x entries below. The correct comparison should start from v3.2.0 (the actual last release).
This is a downstream symptom of the manifest desync flagged in .github/release-please-manifest.json. Fixing the manifest and re-running Release Please will regenerate this file correctly.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@CHANGELOG.md` at line 3, Duplicate CHANGELOG entry: update the new "##
[2.0.0] (2026-02-23)" section to remove duplication and correct its compare
range; specifically, replace the compare URL segment "v1.5.0...v2.0.0" with
"v3.2.0...v2.0.0" (so the heading "## [2.0.0]" matches the existing tag and
shows the right diff), and remove or merge the redundant 2.0.0 block to avoid
two "## [2.0.0]" sections. Then fix the manifest entry in
.github/release-please-manifest.json to set the correct lastRelease (pointing to
v3.2.0) and re-run Release Please to regenerate CHANGELOG.md so the duplicate
and incorrect compare URL are resolved.
| use Mix.Project | ||
|
|
||
| @version "3.2.0" | ||
| @version "2.0.0" |
There was a problem hiding this comment.
Version is being downgraded from 3.2.0 to 2.0.0 — this will break consumers and fail on Hex.pm.
This change regresses the version by one major release series. Concretely:
- Semver regression: Any project depending on
{:commanded, "~> 3.0"}will no longer receive updates from the published package stream. - Hex.pm conflict:
2.0.0was already released on 2025-05-30 (CHANGELOG line 116). Public packages can only be overwritten within one hour after they were initially published, so attemptingmix hex.publishwith this version will be rejected by Hex.pm. - Root cause: The release-please manifest at
.github/release-please-manifest.jsonwas stale at1.5.0, causing Release Please to compute2.0.0instead of the correct4.0.0.
The correct version for this release (given breaking changes from 3.2.0) should be 4.0.0. See the comment on the manifest file for the fix.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@mix.exs` at line 4, The mix.exs `@version` value was incorrectly set to "2.0.0"
causing a semver/regression and Hex.pm publish conflict; update the `@version`
assignment in mix.exs from "2.0.0" to the correct release version "4.0.0" and
also refresh the Release Please manifest (.github/release-please-manifest.json)
so future runs compute the correct next version (ensure the manifest no longer
pins the older 1.5.0 state); verify the change by running your project's
version/check tasks to confirm mix.exs's `@version` reads "4.0.0" before
publishing.
Signed-off-by: Straw Hat Team Bot <61149376+sht-bot@users.noreply.github.com>
5cd84ad to
b9cc239
Compare
|
🤖 Created releases: 🌻 |
2 participants
An automated release has been created for you.
3.3.0 (2026-02-23)
Features
Bug Fixes
This PR was generated with Release Please. See documentation.