chore(main): release 3.0.0 - #23
Conversation
WalkthroughAdds a Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Potential attention points:
Possibly related PRs
Suggested labels
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
CHANGELOG.md (1)
6-8: Consistency nit: capitalize entry to match prior style.Previous bullets often start with “Add …”. Consider “Add support for UUIDv7…” for consistency.
-* add support for UUIDv7 generation and update command options to use UUIDv7 ([#22](https://github.com/straw-hat-team/commanded/issues/22)) ([bb29716](https://github.com/straw-hat-team/commanded/commit/bb297164b97e452b44d138ae3b412f26bd1d55c2)) +* Add support for UUIDv7 generation and update command options to use UUIDv7 ([#22](https://github.com/straw-hat-team/commanded/issues/22)) ([bb29716](https://github.com/straw-hat-team/commanded/commit/bb297164b97e452b44d138ae3b412f26bd1d55c2))
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.md(1 hunks)mix.exs(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Quality Assurance (1.18.x, 27)
🔇 Additional comments (2)
3afac20 to
eb01e9c
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.md(1 hunks)mix.exs(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Quality Assurance (1.18.x, 27)
🔇 Additional comments (1)
mix.exs (1)
4-4: Version bump to 3.0.0 looks correct; verify Git tag creation.The version update matches the CHANGELOG entry for 3.0.0. However, similar to the previous review comment for v2.2.0, ensure the release workflow creates and pushes Git tag
v3.0.0before publishing. Thesource_ref: "v#{@version}"at line 100 will point to this tag, and hexdocs source links will break if the tag is missing.Since this is an automated release-please PR, the workflow should handle tag creation—but please confirm this is configured correctly.
eb01e9c to
de09c2d
Compare
de09c2d to
7be594a
Compare
11819af to
f0ff0d2
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
CHANGELOG.md (1)
6-27: Remove duplicate changelog entries across sections.Three items appear in multiple sections, creating confusion:
- Remove deprecated project macros — listed in both BREAKING CHANGES (line 8) and Miscellaneous Chores (line 27)
- Remove upcast — listed in both BREAKING CHANGES (line 9) and Bug Fixes (line 22)
- Remove process manager — listed in both BREAKING CHANGES (line 10) and Bug Fixes (line 21)
A breaking change is a breaking change; it should not simultaneously appear as a bug fix or misc chore. Keep each entry only in the BREAKING CHANGES section and remove the duplicates from Bug Fixes and Miscellaneous Chores.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.md(1 hunks)mix.exs(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Quality Assurance (1.18.x, 27)
f93eefa to
0508135
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (1)
CHANGELOG.md (1)
11-11: Duplicate breaking change: process manager removal appears in both Breaking Changes and Bug Fixes.As noted in the previous review, issue #24 (remove process manager) is listed in both the BREAKING CHANGES section (line 11) and the Bug Fixes section (line 24). A breaking change should not simultaneously be categorized as a bug fix—it creates confusion for users reviewing the changelog.
Remove line 24 (the process manager entry from Bug Fixes), keeping only the entry in BREAKING CHANGES.
### Bug Fixes * add concurrency validation for Ecto projections ([#33](https://github.com/straw-hat-team/commanded/issues/33)) ([50ec412](https://github.com/straw-hat-team/commanded/commit/50ec4128f9d684bd33820b527e2320f7f788caff)) -* remove process manager ([#24](https://github.com/straw-hat-team/commanded/issues/24)) ([fbe7479](https://github.com/straw-hat-team/commanded/commit/fbe74793f4527f1f73f5beb0e6b08fc27b9049c1)) * remove upcast ([#26](https://github.com/straw-hat-team/commanded/issues/26)) ([9d03039](https://github.com/straw-hat-team/commanded/commit/9d03039812ae934f2177f17e435ddbc59bb804ee))Also applies to: 24-24
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.md(1 hunks)mix.exs(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- mix.exs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Quality Assurance (1.18.x, 27)
0508135 to
05b34c8
Compare
|
🤖 Created releases: 🌻 |
🤖 I have created a release beep boop
3.0.0 (2025-11-21)
⚠ BREAKING CHANGES
Features
Bug Fixes
Miscellaneous Chores
This PR was generated with Release Please. See documentation.
Note
Release 3.0.0 with breaking removals, new Ecto projection features (including batching), UUIDv7 support, timezone-aware timestamps, concurrency validation, and version bump.
init/0and atom metadata key; remove deprecated Ecto projection macros; removeupcast; remove process manager.Commanded.Projections.Ecto; add batch support to Ecto projections; add UUIDv7 support and default usage; implement timezone-aware projection timestamps.CHANGELOG.md; bump@versioninmix.exsto3.0.0.Written by Cursor Bugbot for commit 05b34c8. This will update automatically on new commits. Configure here.