Repository navigation
Reject invalid local chunk sizes before resumable file I/O - #178
Merged
LIghtJUNction merged 2 commits intoSep 29, 2026
Merged
Conversation
Validate positive non-bool integer part_bytes at upload/download entry, before source hashing, journal writes or network requests. Preserve all existing protocol and journal formats. Cloud RED 36561926956: 14 intended failures, 9 passes, no errors/skips; real zero-byte reads do not advance the resume offset. Refs #80, #82, #83, #85.
Contributor
Author
|
最终专项 GREEN 已独立核验:run 36562769933,23/23 唯一 JUnit cases,0 failures/errors/skips。实际 checkout Artifact 11029894918 已下载,ZIP SHA256 a4c49e5260c2bce3b5936ebbdc7f9118f85bc487c8e6967698957f53843cec8c 独立匹配;source.json 和完整JUnit已检查。14个非法输入回归与四协议正常续传及现有5个客户端用例全部通过。 全量存在集成基线的4个失败(只读路径检查1个、Webhook重叠去重3个),不是本PR改动。为避免重复验证/合并,本 PR 全部提交历史已纳入 #179;由 #179 修复这些基线阻塞并统一跑最终全量。请不要单独合并此 PR;#179 接受后再标记 incorporated。 |
LIghtJUNction
merged commit Sep 29, 2026
89990eb
into
integrate/all-open-20260929
10 of 14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #80, #82, #83, #85. Client-only follow-up to #176, independent of #177's server cursor fix. Base
45470b5a46bccfc4f12ef27acccecc2f3bafce47.Fix
Head
517f7e296fa7ef504d2066980454654ed0634598, tree0784e6acad28d37615065c588bb7525efd8295d8.Exactly two inserted runtime lines in
MsgClient.uploadandMsgClient.download: require positive non-bool integerpart_bytesbefore source hashing, journal/partial file access or network requests. Invalid input raisesinvalid_part_bytes. No server code, schema, protocol/journal format or packaging changes. Full modified client blobcffffa10ccbd62249f0ad991e7c81a3cd146cdf6independently matches the prepared two-line diff.Real cloud RED
Run 36561926956, job
109384609384, Python 3.15.0rc2. Regression headcbd4f4f8642e50a10366fd5fe150a4cbd28052a0; actual synthetic checkoutfd6bfce96dea97da81c7679953c5433896a64967has the identical treeb37543923fb4a7ca1503be757fe1f184f44a2749.23 cases: 14 intended failures, 9 passes, 0 errors/skips. The zero-size test records two successful signed zero-byte reads at offset 3 before a third-call guard stops the original non-progressing loop. Invalid downloads fail too late; invalid uploads access the missing source first. All four valid cross-protocol resumes and five existing client tests pass. No timeout, fake successful server response, skip or test correction.
Artifact
11029863272independently downloaded/hashed and source.json/JUnit inspected: SHA256b28e2465340371a16e11307adb0a238bbc4ab7bd861edf650aec7e9a1a30e5f8.Verification
Final head has been pushed to trigger cloud verification. Both focused and full four-shard completeness/conformance/build gates still need final inspection; no green claim yet. Tests require zero requests and unchanged local file hashes/modes/mtimes on rejection, with real PostgreSQL read-only evidence and exact-byte normal resume over HTTP/PathGET/GraphQL/MCP.
Notes:
docs/CLIENT_PART_BYTES_PROGRESS.md. No local project execution, production action or broad issue closure.