[Birfy]

Written-by: Dev

Owner: Birfy
Reviewer: Reviewer

Fixes #963

What changed

After a friend named Chief was added, the owner's own Chief was painted pink. The @Name file chip was keyed only by display name, so the friend's color replaced the local Bot's. A friend's chat could also take the local Bot's id in the roster index, and a group icon drew the friend's seat on top of the local Bot.

A local Bot now keeps its stored look (the blue whale / deepseek). The friend's own row stays on the friend's color.

Reload FlyBot (or update to this build). The stored local color was not overwritten, so there is no migration. The friend Chief (flybot98b8ecba) staying pink is expected.

Verification at the tip

Tip SHA: eeadbde

The previous tip 5215fb8 failed tests-ok at test/follow-through.test.js:159 (settle helper at line 113): inflight notes were not empty after a restart pickup. That test does not load the client. The color change does not touch core/src/host/resume.js. The same assertion did not fail in TZ=UTC npm run verify on Node 24 (1391 core tests). This tip is that branch merged onto current main (a59ec19).

Ran:

• TZ=UTC npm run verify on Node 24.11.0 — pass: core 1391, social 407, tree 125, timeline 125, github scripts 400, interop 37, live-e2e 16.
• node scripts/ds-bot-patches.mjs check — pass.
• node core/scripts/check-arch-docs.mjs — pass (19 changed files).

Not run (and why):

• dev/bench.sh smoke. Display-only client code. No core/index.js or core/src/host/ change in this fix.

  

[cursor]

Verdict: PASS at 5215fb8
Written-by: Reviewer

Local Chief keeps its stored look when a friend shares the name. The @Name file chip uses the local Bot, the roster index does not let a remote chat replace a local id or session, and a group icon paints the local seat in front. The friend's own row stays on the friend's color. docs/subsystems/core-client.md records the invariant. No host change, no stored-color migration.

Ran:

• $ node --import ./test/harness-resolve.mjs --test test/local-look.test.js — before the fix this failed to load (ERR_MODULE_NOT_FOUND: cluster-order.js); at this tip it is included in the suite below
• $ TZ=UTC npm run verify — pass: core 1390, social 402, tree 125, timeline 125, github scripts 389, interop 37, live-e2e 16
• $ node .github/scripts/changelog.mjs check — pass
• $ node core/scripts/check-arch-docs.mjs — pass (19 changed files)
• $ node scripts/ds-bot-patches.mjs check — pass

Not run:

• dev/bench.sh smoke — display-only client change; no core/index.js or core/src/host/ edit
• CI pack, typecheck, and actionlint — not part of npm run verify

[Birfy]

Verdict: PASS at 5215fb8
Written-by: Reviewer

Local Chief went pink after adding a friend named Chief: @name chip CSS, roster byId, and group RoomAvatar all let the later remote seat overwrite the local look. Fix keeps local Bot look for shared names; friend row stays pink.

Ran: TZ=UTC npm run verify
(core 1390, social 402, tree 125, timeline 125, scripts 389, interop 37, live-e2e 16; fail 0, at 5215fb8)

Not run: Desktop visual check on live homes.

[Birfy]

Verdict: PASS at eeadbde
Written-by: Reviewer

Local Chief keeps its stored look when a friend shares the name (@name chip, roster byId, group RoomAvatar). Friend row stays pink. Rebased onto current main; prior CI flake in follow-through was unrelated.

Ran: TZ=UTC npm run verify (agent report: core 1391, social 407, tree 125, timeline 125, scripts 400, interop 37, live-e2e 16; fail 0)
GitHub Actions tests-ok green at eeadbde.

Not run: Desktop visual on live homes.