Repository navigation
Face-to-face room @ menu: no DSH Sessions rows, Everyone counts its Bots - #431
Merged
Merged
Conversation
DSH's built-in reference source cannot be dropped for one Session (ThinkFlowLab#422), so in a face-to-face room FlyBot watches the Session's trigger controller: CSS hides the Session rows and their section title, the highlight is moved past them, and a menu with nothing else is dismissed so Enter sends. Everyone in a group counts the Bots it reaches, 1 member / N members. Fixes ThinkFlowLab#305
Collaborator
Author
Self-review (Birfy, owner's Bot)Read the full diff at the tip against main.
Verdict: PASS |
This was referenced Oct 19, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #305
What is left of #305 after #425 (one name per Bot):
@menu without DSH's Sessions rows (owner decision: filter in FlyBot for now; DSH request: let a plugin hide the shell's Sessions rows in a room's @ menu (replace FlyBot's filter) #422 stays open for a DSH API). DSH's built-inreferencesource cannot be dropped for one Session, so for a face-to-face roomHeaderPillstartsactions.filterFaceAtMenu, which watches that Session's trigger controller (inputTriggers.sessionOf, the one the composer uses; FlyBot already uses it for "Reference a chat"). Newface-at-filter.js: a<style data-bt-face-at>hides thereferencerows whose icon issession(Sessions and Subagents) and their section title, by MenuView's option ids;controller.hovermoves the highlight past them in the direction of the key, so arrow keys skip them and Enter never picks a hidden row; a menu with nothing else left isdismiss()ed, so Enter sends. File rows stay. No DSH patch.1 member/2 members(also the palette's group subtitle). Face rooms keepEvery Bot in this room.Bot (owner)naming (One name for a friend's Bot: Bot (owner), everywhere #425), the mention chip with@, the same label on both homes and no doubled space (Face-room @ chips: one name on both homes, with @, and no doubled space (part of #305) #367/Face-room @ chips: my own bare @Chief stays my Chief whatever the seat order (#305 follow-up) #368, testmention-rule.test.js).Tests:
core/test/face-at-filter.test.js(rows and titles hidden, files and Bots kept, highlight steering both ways, dismiss when only Session rows are left, watcher clean-up),core/test/at-menu.test.js(Everyone count). Docs:docs/subsystems/core-client.md. Changelog:changelog.d/305-face-room-at-menu.fixed.md.Ran:
ARCH_DOCS_BASE=origin/main TZ=UTC npm run verifyat 592d535 (core 966+ tests, social, tree, timeline, scripts, interop, live-e2e: all pass);node core/scripts/build-client.mjs --check;node scripts/ds-bot-patches.mjs check.Not run: smoke bench; a live two-home browser check of the face-room
@menu in DSH Desktop (the CSS relies on MenuView'sdsh-slash-option-<source>-<index>ids and:has(), checked against DSH 0.2.0-rc.2).