Skip to content

Face-to-face room @ menu: no DSH Sessions rows, Everyone counts its Bots - #431

Merged
Birfy merged 2 commits into
ThinkFlowLab:mainfrom
Birfy:fix/305-face-room-at-picker
Oct 19, 2026
Merged

Birfy merged 2 commits into
ThinkFlowLab:mainfrom
Birfy:fix/305-face-room-at-picker

Conversation

@Birfy

@Birfy Birfy commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator

Fixes #305

What is left of #305 after #425 (one name per Bot):

Tests: core/test/face-at-filter.test.js (rows and titles hidden, files and Bots kept, highlight steering both ways, dismiss when only Session rows are left, watcher clean-up), core/test/at-menu.test.js (Everyone count). Docs: docs/subsystems/core-client.md. Changelog: changelog.d/305-face-room-at-menu.fixed.md.

Ran: ARCH_DOCS_BASE=origin/main TZ=UTC npm run verify at 592d535 (core 966+ tests, social, tree, timeline, scripts, interop, live-e2e: all pass); node core/scripts/build-client.mjs --check; node scripts/ds-bot-patches.mjs check.
Not run: smoke bench; a live two-home browser check of the face-room @ menu in DSH Desktop (the CSS relies on MenuView's dsh-slash-option-<source>-<index> ids and :has(), checked against DSH 0.2.0-rc.2).

Birfy added 2 commits October 19, 2026 17:03
DSH's built-in reference source cannot be dropped for one Session (ThinkFlowLab#422),
so in a face-to-face room FlyBot watches the Session's trigger controller:
CSS hides the Session rows and their section title, the highlight is moved
past them, and a menu with nothing else is dismissed so Enter sends.
Everyone in a group counts the Bots it reaches, 1 member / N members.

Fixes ThinkFlowLab#305
@Birfy Birfy self-assigned this Oct 19, 2026
@Birfy Birfy added agent-pr Pull request opened by an agent bug Something isn't working area:ui Web/desktop UI and copy area:social Friends, invites, grants, Bot Social labels Oct 19, 2026
@Birfy

Birfy commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator Author

Self-review (Birfy, owner's Bot)

Read the full diff at the tip against main.

Verdict: PASS
Tip SHA: 592d535
Ran: ARCH_DOCS_BASE=origin/main TZ=UTC npm run verify at 592d535 (all suites pass), build-client.mjs --check, ds-bot-patches.mjs check; CI tests-ok green at the tip.
Not run: smoke bench; a live two-home browser check of the face-room @ menu in DSH Desktop.

@Birfy Birfy added the awaiting-approval PR is green and waits for the maintainer's approval (T2/T3) or a review PASS at its tip label Oct 19, 2026
@Birfy
Birfy added this pull request to the merge queue Oct 19, 2026
Merged via the queue into ThinkFlowLab:main with commit c5d9c3f Oct 19, 2026
8 checks passed
@Birfy
Birfy deleted the fix/305-face-room-at-picker branch October 19, 2026 09:09
@Birfy Birfy removed awaiting-approval PR is green and waits for the maintainer's approval (T2/T3) or a review PASS at its tip agent-pr Pull request opened by an agent labels Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:social Friends, invites, grants, Bot Social area:ui Web/desktop UI and copy bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Face room @ picker lists a friend's Bot 5 times in 3 sections, 'Everyone · 1 members'; mention chip renders differently per home; Bot named 4 ways

1 participant