Repository navigation
Face-room @ chips: my own bare @Chief stays my Chief whatever the seat order (#305 follow-up) - #368
Merged
Merged
Conversation
…t order (ThinkFlowLab#305 follow-up) Codex P1 on ThinkFlowLab#367: on the home that joined later the room can list the friend's seat first, and for a locally typed line the bubble then bound a bare @chief to the friend's Chief while the host called the local one. Local seats now come first for my lines, the friend's for a friend's line, mirroring faceCandidates.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 18, 2026
Birfy
added a commit
to Birfy/FlyBot
that referenced
this pull request
Oct 19, 2026
…ots (ThinkFlowLab#431) Fixes ThinkFlowLab#305 What is left of ThinkFlowLab#305 after ThinkFlowLab#425 (one name per Bot): - **Face room `@` menu without DSH's Sessions rows** (owner decision: filter in FlyBot for now; ThinkFlowLab#422 stays open for a DSH API). DSH's built-in `reference` source cannot be dropped for one Session, so for a face-to-face room `HeaderPill` starts `actions.filterFaceAtMenu`, which watches that Session's trigger controller (`inputTriggers.sessionOf`, the one the composer uses; FlyBot already uses it for "Reference a chat"). New `face-at-filter.js`: a `<style data-bt-face-at>` hides the `reference` rows whose icon is `session` (Sessions and Subagents) and their section title, by MenuView's option ids; `controller.hover` moves the highlight past them in the direction of the key, so arrow keys skip them and Enter never picks a hidden row; a menu with nothing else left is `dismiss()`ed, so Enter sends. File rows stay. No DSH patch. - **Everyone's count** in a group now counts the Bots it reaches (local members plus seated friends' Bots), with singular/plural: `1 member` / `2 members` (also the palette's group subtitle). Face rooms keep `Every Bot in this room`. - Already on main, checked: one row per Bot in a face room (ThinkFlowLab#339), `Bot (owner)` naming (ThinkFlowLab#425), the mention chip with `@`, the same label on both homes and no doubled space (ThinkFlowLab#367/ThinkFlowLab#368, test `mention-rule.test.js`). Tests: `core/test/face-at-filter.test.js` (rows and titles hidden, files and Bots kept, highlight steering both ways, dismiss when only Session rows are left, watcher clean-up), `core/test/at-menu.test.js` (Everyone count). Docs: `docs/subsystems/core-client.md`. Changelog: `changelog.d/305-face-room-at-menu.fixed.md`. Ran: `ARCH_DOCS_BASE=origin/main TZ=UTC npm run verify` at 592d535 (core 966+ tests, social, tree, timeline, scripts, interop, live-e2e: all pass); `node core/scripts/build-client.mjs --check`; `node scripts/ds-bot-patches.mjs check`. Not run: smoke bench; a live two-home browser check of the face-room `@` menu in DSH Desktop (the CSS relies on MenuView's `dsh-slash-option-<source>-<index>` ids and `:has()`, checked against DSH 0.2.0-rc.2).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #367, part of #305. Fixes the Codex P1 on #367, which was merged before that review finished.
Problem: on the home that joined later, the room can list the friend's seat before mine. If both Bots are called
Chief, a bare@Chiefthat I typed was drawn (and opened) as the friend's Chief, while the host called my own Chief (faceCandidatesputs local candidates first).Fix (
core/src/client/user-message.js): for my own line, my seats come first; for a friend's line, the friend's seats come first. The room's seat order no longer matters.Test: the #305 test in
core/test/mention-rule.test.jsnow also lists the friend's seat first. It fails without the fix.No changelog fragment: this fixes an unreleased change whose
305-mention-chipfragment already describes the behaviour.Ran at the tip:
TZ=UTC ARCH_DOCS_BASE=upstream/main npm run verify(green) andds-bot-patches check. Not run: a browser pass.