Skip to content

Settings polish: Bot Social features in words, Harness settings marked as separate, row gear never shifts the page - #423

Merged
Birfy merged 3 commits into
ThinkFlowLab:mainfrom
Birfy:fix/421-settings-polish
Oct 19, 2026
Merged

Birfy merged 3 commits into
ThinkFlowLab:mainfrom
Birfy:fix/421-settings-polish

Conversation

@Birfy

@Birfy Birfy commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator

Fixes #421

Docs: core-client.md, social.md. Changelog fragment added. zh strings added.

Ran at tip 528af2e: TZ=UTC ARCH_DOCS_BASE=upstream/main npm run verify (green, Node 24). Not run: a live browser check of the gear shift (no browser pair this run), smoke test (no host change).

@Birfy Birfy added bug Something isn't working agent-pr Pull request opened by an agent area:social Friends, invites, grants, Bot Social area:ui Web/desktop UI and copy labels Oct 19, 2026
@Birfy Birfy self-assigned this Oct 19, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T06:46:46.807607Z 8f7e8ba Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 528af2e27f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/social/client.js Resolved
@Birfy

Birfy commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 8f7e8badbf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Birfy

Birfy commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator Author

Self-review (owner's Bot, selfReview per owner decision 2026-10-19 11:43). Not merge authority: this T2 PR still needs the maintainer's approval on GitHub.

Tip SHA: 8f7e8badbf81469ebbf14b704d8d32ca98f9a86d
Ran:
  - TZ=UTC ARCH_DOCS_BASE=upstream/main npm run verify (Node 24, harness 0.2.0-rc.2) → pass
  - CI tests-ok at this tip → pass
Not run:
  - live browser check of Settings (Bot Social page, Harness settings ↗, gear focus) — no bench this run
  - smoke test — no change to core/index.js or src/host
OpenCode↔Codex: n/a
Verdict: PASS

Findings: no actionable findings. Codex P2 (feature ids that name Object.prototype members) fixed at this tip with Object.hasOwn, covered by the #421 test; Codex re-review gave 👍; thread resolved. Design check: English copy, features in words with raw ids only in the tooltip, Harness settings clearly marked as leaving FlyBot (↗), no new controls, gear no longer jumps the sidebar.

@Birfy Birfy added the awaiting-approval PR is green and waits for the maintainer's approval (T2/T3) or a review PASS at its tip label Oct 19, 2026
@Birfy
Birfy added this pull request to the merge queue Oct 19, 2026
Merged via the queue into ThinkFlowLab:main with commit 8753207 Oct 19, 2026
8 checks passed
@Birfy
Birfy deleted the fix/421-settings-polish branch October 19, 2026 06:55
@Birfy Birfy removed awaiting-approval PR is green and waits for the maintainer's approval (T2/T3) or a review PASS at its tip agent-pr Pull request opened by an agent labels Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:social Friends, invites, grants, Bot Social area:ui Web/desktop UI and copy bug Something isn't working

Projects

None yet

1 participant