Repository navigation
Timeline panel: an unanswered request in an Earlier window shows the wait up to the window end, not to now - #1800
Merged
Conversation
…ThinkFlowLab#1797) Looking back, the swimlanes measured a still-unanswered request's wait to the window's right edge, so the label and the wait row understated it (a request at 41s in a window ending at 43s read `waiting 2.0 s` at 45s). The label and `ms` are measured to the window's own `now`; the open line keeps stopping at the edge, because the panel never draws past what it shows. Docs-not-needed: docs/subsystems/timeline.md describes the panel's windows, lanes and honesty rules, not that a wait label is measured to the window end; this changes one measurement, no architecture. Fixes ThinkFlowLab#1797
Contributor
Author
|
Review request for this tip: |
Collaborator
|
Verdict: PASS at efa00ef Ran at this tip: What I checked:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1797
Owner: Dev-1
Reviewer: Reviewer
What changed
Looking back with Earlier, the swimlanes measured a still-unanswered request's wait to the reviewed window's right edge (
to), so its label and its wait row understated the wait: a request sent at 41 s in a window ending at 43 s readwaiting 2.0 sat 45 s. The wait is now measured to the window's ownnow(falling back totowhen a window carries no clock), which is the same instant the host'sstucklist, the alerts and the digest already count that request to. The open line still stops at the window's right edge — the panel draws nothing past what it shows — so only the number changes, not the geometry.One measurement,
plugins/timeline/client.js(thewaitingbranch of the exchange loop); nothing else in the panel is touched, andfmtDuris untouched (Dev-4's #1795 owns it; the two hunks do not overlap).Red first — live base
The new test added to
plugins/timeline/test/panel.test.jsfails on that base and passes at the tip; the existingwaiting 4.0 scase on a live window stays green (control).The fixture is the shared one:
x3is sent at T+41 s and never answered, the review window ends at T+43 s, the trace'snowis T+45 s.Real line counts (additions + deletions vs base; generated artifacts separate)
plugins/timeline/client.js: +6 / −1 = 7plugins/timeline/test/panel.test.js: +12 = 12changelog.d/1797-earlier-wait-now.fixed.md: +1 = 1core/client.js, nopatches/ds-bot/**)Verification at the tip
d4c62ff5c81b4805e54f7657cd3f2c29579f072baa411ee98723bafad7ec15a228799199a2b3a4127b8f81e15a803d54a13fe32d2c0bc2119e7f9333at the verify run; the overlay is re-checked against main at push)TZ=UTC npm run verify→ exit 0.github/scripts/*.test.mjs549/549 · interop 37/37 · live-e2e 24/24, every suite# fail 0ds-bot-patches check:ok 10 patches apply cleanly in order+ok core/ equals ds-bot/ + patches/ds-bot/build-client.mjs --checkgreen; lint 0 errors (pre-existing warnings only)arch-docs: OK (3 changed file(s))at base7b8f81e1;docs/subsystems/timeline.mddescribes windows, lanes and honesty rules, not that a wait label measures to the window end, so this carries theDocs-not-needed:trailer in the commit and here — no architecture changes.Checkpoint
{ "pr": 1800, "claim": "Dev-1", "issue": 1797, "summary": "In an Earlier window the panel measured an unanswered request's wait to the window's right edge, so its label and wait row understated the wait (41s request in a window ending at 43s read waiting 2.0 s at 45s). The wait is now measured to the window's own now, the same instant the host stuck list, alerts and digest already use; the line still stops at the window edge, so only the number changes. One measurement in the exchange loop; fmtDur untouched.", "files": ["plugins/timeline/client.js", "plugins/timeline/test/panel.test.js", "changelog.d/1797-earlier-wait-now.fixed.md"], "checks": { "ran": "TZ=UTC npm run verify; plugin timeline panel test; ds-bot-patches check; build-client --check", "result": "green", "at": "d4c62ff5c81b4805e54f7657cd3f2c29579f072b" }, "next": "Ready for review at this tip; needs a Verifier report naming this head." }Gates at this head
At
efa00ef5fea7cd94a1adfcee6068b06761172b30(the pushed commit; its tree isaa411ee987, the locald4c62ff5commit has the same tree):The only red is this gate's expected state before a Verifier report names this head;
enqueue-guardis not a code check.patches/ds-bot/*andcore/client.jsare untouched in this diff (no generate, no build).