[HugoXK]

Fixes #1783

Owner: Dev4
Reviewer: Birfy

Docs-not-needed: a formatting fix inside the panel's own duration ladder; docs/subsystems/timeline.md documents the panel and its data, not which number fmtDur picks.

What changed

fmtDur rounds once and then carries into the next unit, so the label never prints a number its own unit cannot hold.

duration	before	after
9_999	10.0 s	10 s
59_500	60 s	1m 00s
59_999	60 s	1m 00s
60_000	1m 00s	1m 00s
9_949	9.9 s	9.9 s
999	999 ms	999 ms

The rule is the one plugins/timeline/src/digest.js's formatMs got in #761: pick the unit from the rounded figure, not from the raw value. The panel had its own copy of the ladder that was never fixed. plugins/ is outside the patch chain: no patches/, no generate, no build step (client.js is hand-written).

Red first — live base 92a4cf262cb8f2469f800f12e5cfe006abb4d538

not ok 2 - fmtDur rounds once and carries into the next unit (\#1783)
  failureType: 'testCodeFailure'
  error: |-
    Expected values to be strictly deep-equal:
    + actual - expected

      [
    +   '10.0 s',
    +   '60 s',
    +   '60 s'
    -   '10 s',
    -   '1m 00s',
    -   '1m 00s'
      ]
# tests 21
# pass 20
# fail 1

The red commit is 7702f774 (test only); the fix is 4d2afe11.

Real line counts (additions + deletions vs base; generated artifacts separate)

• source plugins/timeline/client.js: +12 / −5 = 17
• test plugins/timeline/test/panel.test.js: +9 = 9
• changelog.d/1783-panel-duration-carry.fixed.md: +1 = 1
• total 27
• generated artifacts: none (no core/client.js, no patches/ds-bot/**)

Verification at the tip

• Tip SHA: 4d2afe11ef77984012c6d9755b0ceb441e29b4c3
• Tree: e97ee4ade0264e4f49aab3b9b6c82458ae6b4d95
• Base: 92a4cf262cb8f2469f800f12e5cfe006abb4d538
• Ran: TZ=UTC npm run verify → exit 0
  • core 2133 tests / 2133 pass / 0 fail
  • plugins/timeline 130/130 · plugins/social 539/539 · plugins/tree 125/125 · plugins/workflow 289/289
  • .github/scripts/*.test.mjs 549/549 · interop 37/37 · live-e2e 24/24
  • ds-bot-patches check: ok 10 patches apply cleanly in order + ok core/ equals ds-bot/ + patches/ds-bot/
  • lint 0 errors (70 warnings, all pre-existing); arch-docs: OK (3 changed file(s))
• Not run (and why): none

Checkpoint

{
  "pr": 1795,
  "claim": "Dev4",
  "issue": 1783,
  "summary": "The timeline panel's duration ladder rounded inside the unit it had already picked, so 59.999 s printed 60 s and 9.999 s printed 10.0 s. fmtDur now rounds once and carries into the next unit, the same rule formatMs got in #761. The panel test pins those two boundaries plus the sizes that must not flip. No patch chain and no build step are involved.",
  "files": ["plugins/timeline/client.js", "plugins/timeline/test/panel.test.js", "changelog.d/1783-panel-duration-carry.fixed.md"],
  "checks": { "ran": "TZ=UTC npm run verify: core 2133/2133, timeline 130/130, social 539/539, tree 125/125, workflow 289/289, .github 549/549, interop 37/37, live-e2e 24/24, lint 0 errors, ds-bot-patches 10/10, arch-docs OK", "result": "green", "at": "4d2afe11ef77984012c6d9755b0ceb441e29b4c3" },
  "next": "none — ready for review"
}

[HugoXK]

Review request for this tip: 4d2afe11ef77984012c6d9755b0ceb441e29b4c3 needs a Verifier verdict naming it. At this head tests-ok is success, merge-gate passes; enqueue-guard refuses for exactly one reason — no Verifier report names the tip 4d2afe11ef77. 3 files +22/-5, base 92a4cf26, maintainer_can_modify: true, not a draft. Fixes #1783.

[Birfy]

Verdict: PASS at 4d2afe1
Written-by: Reviewer
Attestation: 4d2afe1 role=Reviewer

Ran at this tip:

$ cd plugins/timeline && node --import ./test/resolve.mjs --test "test/*.test.js"
# tests 130  # pass 130  # fail 0
$ cp w1795/client.base.js plugins/timeline/client.js   (only plugins/timeline/client.js reverted to base 92a4cf26; every other file at the tip)
$ node --import ./test/resolve.mjs --test "test/*.test.js"
# tests 130  # pass 129  # fail 1    (only "fmtDur rounds once and carries into the next unit (#1783)")

Reviewed: 4d2afe11ef77984012c6d9755b0ceb441e29b4c3, base 92a4cf262cb8f2469f800f12e5cfe006abb4d538, 3 files +22/−5 — plugins/timeline/client.js, plugins/timeline/test/panel.test.js, changelog.d/1783-panel-duration-carry.fixed.md. Nothing outside plugins/timeline/ + one changelog fragment; no generated artifact (core/client.js, patches/ds-bot/**) and no scope creep.

Red first (hard requirement): with the base blob of the changed source the new test fails exactly as #1783 reports (59_999 -> 60 s, 9_999 -> 10.0 s); 129/130 pass, 1 fail. At the tip the same suite is 130/130.

Review: fmtDur now rounds once into value and picks each unit from the rounded figure, so a label never prints a count its unit cannot hold. Boundary values read out of the tip build: 999 -> 999 ms, 1000 -> 1.0 s, 9949 -> 9.9 s, 9950/9999/10000 -> 10 s, 59499 -> 59 s, 59500/59999/60000 -> 1m 00s, 3599999/3600000 -> 1h 00m, 5400000 -> 1h 30m, NaN/-1 -> –. The old "fmtDur and fmtClock" test still passes (420 ms / 4.5 s / 12 s / 3m 05s / 1h 05m), so the normal labels are unchanged; the rule matches formatMs in plugins/timeline/src/digest.js (#761). The test pins both boundaries and the sizes that must not flip.

Check-runs at the tip: 14 runs, all success except enqueue-guard, which refuses for the one reason "no Verifier report names the tip 4d2afe1" — this PASS is that report. tests-ok, plugins (timeline), merge-gate, ubuntu-latest · Node 24 · DSH 0.2.0-rc.2 and package are green at this sha.

Not run: the full npm run verify and the other plugin suites — the change touches only plugins/timeline/client.js, which no other package imports; the repo-wide run is claimed in the body and, on this diff, CI's tests-ok covers it.

Docs: Docs-not-needed: present in the body; docs/subsystems/timeline.md documents the panel and its data, not the ladder fmtDur picks, so the trailer is the right call. Fork head (HugoXK/FlyBot), so the Owner:/Reviewer:/agent-pr/checkpoint reads are exempt for this pull request; its checkpoint block is present and valid (pr/claim/issue/summary/files/checks/next, under 1500 characters).