Repository navigation
fix(social): Open/Closed status chip contrast and Past rooms spacing (#170) - #174
Conversation
Face room details showed a low-contrast lowercase open chip; past-room rows crowded the Open control against avatars and status chips. Docs-not-needed: CSS-only face status chip labels and past-row spacing. Fixes ThinkFlowLab#170 Co-authored-by: Danyang Chen <birfychen@gmail.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5d2979fbd7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| function faceChipLabel(room) { | ||
| const chip = faceChip(room) | ||
| if (chip === 'open') return 'open' | ||
| if (chip === 'open') return 'Open' |
There was a problem hiding this comment.
When this commit is checked against its main parent, the Lint step in .github/actions/flybot-tests/action.yml:41-62 fetches origin/main, and check-arch-docs.mjs will see an owned plugins/social/ change but neither a docs/subsystems/social.md edit nor a Docs-not-needed: trailer, so the required gate fails. The doc is substantively stale too (docs/subsystems/social.md:69 still says the live chip reads open), so update it for Open rather than waiving this label change.
AGENTS.md reference: AGENTS.md:L94-L94
Useful? React with 👍 / 👎.
Fixes #170
Summary
Open(was lowercaseopen) with stronger contrast, readable in light and dark.data-flybot="face-status".Styling and label only; no new buttons or copy. Fork PR: Birfy#20
Test plan
ARCH_DOCS_BASE=upstream/main npm run verify(agent run, Node 24)Openchip with readable contrast