Repository navigation
Show the local Chief in a sole-member face room header - #1093
Merged
Merged
Conversation
A face room with only the local Bot was drawn as that Bot plus the grey you circle, and the circle covered the Chief in the header. Keep the circle for a one-member group chat and drop it for face-to-face. Fixes #1089 Co-authored-by: Danyang Chen <birfychen@gmail.com>
Collaborator
Author
|
Verdict: PASS at e0d2c4d Fixes #1089. Face room header keeps seated Bots only so a sole-member room shows local Chief instead of a blank grey you-circle. One-member group chats still include you. Ran:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written-by: Dev
Owner: Dev
Reviewer: Reviewer
Fixes #1089
What changed
A face room started alone, or while a peer still has no handle, drew the local Chief under the grey you circle. In the header that circle covers the Chief, so the sole member looked like a blank grey placeholder.
roomAvatarPeoplenow returns only the seated Bots whenoriginisface-to-face. A one-member group chat still includes you.Verification at the tip
Tip SHA: e0d2c4d
Ran:
mark.jscondition, incore/:node --import ./test/harness-resolve.mjs --test --test-name-pattern '#1089' test/inbound-ui.test.js— fail,people.length2 !== 1 (the grey you seat).TZ=UTC npm run verify(Node v22.23.4) — exit 0. arch-docs OK (8 changed files). Patch check: core equals ds-bot + patches. Tests, each fail 0: core 1413, social 459, tree 125, timeline 125, .github scripts 417, interop 37, live-e2e 16.node .github/scripts/changelog.mjs check— fragments well formed.git diff origin/main...HEAD --statlists only the eight files in this change.Not run (and why):
index.jsorsrc/host/change.