[Birfy]

Written-by: Dev
Owner: Dev
Reviewer: Reviewer

Fixes #1068

What changed

A friend DM stayed on "Weighing the options…" when the other home's turn died (for example MISSING_CREDENTIAL) and nothing came back. That home now sends one of two fixed sentences — no model set up, or could not answer — and never the provider text. The social plugin lets that notice through the reply hold and clears a blanket server hold. A lookalike, the same words on an auto-reply, and a hold with a finding of its own still wait for the owner. A notice that comes back does not earn another.

Verification at the tip

Tip SHA: 58cf42ec0e220d019aafb7ab30dec3f1a90b1323

Ran:

• TZ=UTC npm run verify at this tip → pass (core 1417, social 456, tree 125, timeline 125, github scripts 417, interop 37, live-e2e 16; patch check inside it)
• node core/scripts/check-arch-docs.mjs at this tip → pass (11 changed files)
• node .github/scripts/changelog.mjs check at this tip → pass
• node --import ./test/harness-resolve.mjs --test --test-name-pattern '#1068' test/bot-messages.test.js (core) at this tip → 6 pass
• node --import ./test/resolve.mjs --test --test-name-pattern '#1068' test/social.test.js at this tip → 3 pass

Not run:

• Smoke bench (dev/bench.sh): no deepseek-harness checkout here. The change is the remote-reply path, covered by the unit tests above.
• GitHub tests-ok: not this run.

Red at base c062fb02c3317990e77c1abb273e1350546136db (defect tests, before the fix):

• Core #1068: 5 fail (sent.length 0; a hard failure called no flybotReplyRemote). Green at the tip (6 pass).
• Social #1068: the notice was hold, not allow. Green at the tip (3 pass).

  

[cursor]

Verdict: PASS at 58cf42e
Written-by: Reviewer

Ran:

• TZ=UTC npm run verify → pass (core 1417, social 456, tree 125, timeline 125, github scripts 417, interop 37, live-e2e 16; patch check ok)
• node core/scripts/check-arch-docs.mjs → pass (11 changed files)
• node .github/scripts/changelog.mjs check → pass
• node --import ./test/harness-resolve.mjs --test --test-name-pattern '#1068' test/bot-messages.test.js (core) → 6 pass
• node --import ./test/resolve.mjs --test --test-name-pattern '#1068' test/social.test.js → 3 pass

Not run:

• Smoke bench (dev/bench.sh) — no deepseek-harness checkout in this environment. The change is the remote-reply path, covered by the unit tests above.
• GitHub tests-ok — not this run.

Defect tests were red on base c062fb02c3317990e77c1abb273e1350546136db before the fix (core: 5 fail, no flybotReplyRemote on a hard failure; social: the notice was hold, not allow) and green at this tip.

No actionable findings. The notice is one of two fixed sentences; the provider text is not copied, so a missing-key failure cannot echo part of a key. AUTH stays the generic sentence. The same words on auto-reply, or any other text on turn-failed, stay held. A Bot Social hold with a finding of its own keeps its card. A line whose body is already a notice does not earn another.

This PASS is not merge authority. Enqueue waits on tests-ok green at this tip.

[Birfy]

Verdict: PASS at 58cf42e
Written-by: Reviewer

Fixes #1068. Hard remote DM failure sends a fixed notice and clears the weighing hold instead of hanging on "Weighing the options…".

Ran:

• TZ=UTC npm run verify → pass (core 1417, social 456, tree 125, timeline 125)
• Friend DM stays on "Weighing the options…" when remote Bot turn fails #1068 tests red on base, green at tip