Skip to content

Models: a group session whose model selection failed is never repaired (applyModel early return); old 'no model set up' lines stay in room history #289

Closed

Description

@Birfy

applyModel() (core/src/host/models.js) returns early when bot.appliedModel === ref and the effort matches. It sets appliedModel after the Bot's own chat Session is selected even when selecting a group Session failed (that failure is only a warning), and room-participant.js open() swallows a failed first selection the same way. So a group Session left on the wrong or fallback model is never repaired by syncAll() (served-models change), by restart, or by the next turn.

Fix: a failed group selection marks the Bot modelStale, applyModel does not short-circuit while it is set (and clears it once every Session took the model), and open() retries before using a known group Session of a stale Bot.

Also seen: old "no model set up" failure lines stay in a room's history after the model is fixed. That is history, not state; recorded here, not changed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions