[Birfy]

Refs #645

Tip SHA: 57d69d4
Docs-not-needed: core/dev/smoke.mjs only follows the silent-creation behaviour; docs/subsystems/ds-bot-core.md describes what the script is for, not its bootstrap steps.

Creating a Bot or a group chat no longer starts work before the user asks. A new Bot is sent no greeting: the [Bot team setup] kickoff, the kickoff delivery role, the held greeting and the model-pick greeting are gone. A new group posts no opening round, and create-room's greet option is gone. A line the user typed in the composer before creating a Bot is sent to it as one user turn, so the Bot answers it, and it is never saved as the Bot's instructions; a brief becomes instructions only when another Bot creates the Bot (create_bot). A Bot's first turn is otherwise the user's first line.

#645 is five proposals and this is A: B (idle default), C (activity budget) and E (quiet hours) stay open, hence Refs, not Fixes.

Reproduce

On main before this change, making a team speaks to every Bot at once:

• core/src/host/roster.js built a kickoff text on every createBot and delivered it with role kickoff, so creating three Bots delivered three messages.
• core/src/host/groups.js (roomKickoff, greetRoom, the openingSpeakers kickoff branch) posted a "The user just created this group" round on create-room with greet: true, and the client always sent that flag.
• The new tests in this PR fail on that tree: they assert sent is empty after three create-bot calls and one create-room, and that the first user message then opens exactly one admin turn.
• The INC this tip answers: create a Bot from the sidebar composer with "帮我写周报" typed in the box. new-chat.js passed that line to the card as brief, the host folded it into instructions as Why you exist: 帮我写周报, and the new chat opened empty — a request the user typed became a standing rule and got no answer.

What changed

• core/src/host/roster.js: no kickoff text, no sendKickoff/dropKickoff, no waiting/bot.kickoff held greeting, no greeting in updateBot or setMain; createSession's copyOf parameter is gone. A brief joins instructions as Why you exist: <brief> only when createdBy names a Bot: a parent's context, as create_bot passes it. A create-bot request with a brief (the new-Bot card, any client) leaves the instructions alone.
• core/src/client/new-chat.js, create-bot.js, bot-draft.js: the card carries no brief and createPayload has no brief field. created sends the composer's line to the new Bot with one actions.send before it opens the chat, the way opening an existing Bot and creating a group do, and CreateBot awaits onCreated so a failed send shows in the form.
• core/src/host/parts.js: historyEntry still skips a source.role === 'kickoff' line, so a transcript written before this change does not surface its old greeting prompt as the Bot's own words (and keep the answers after it). core/test/history.test.js keeps the assertion.
• core/src/host/groups.js: roomKickoff, greetRoom/rt.greetRoom, the kickoff branch of roomPrompt, openingSpeakers and isPlainFaceLine, and the round's kickoff note and guard are removed.
• core/src/host/channel.js: create-room has no greet option; turns.js has no kickoff queue branch and no dropKickoff call; delivery.js no longer writes the [Bot team setup] header.
• core/src/host/tools.js: create_bot says the new Bot starts no turn instead of "greeting the user now".
• Client: new-chat.js and group-settings.js stop sending greet: true, and cells.js no longer draws a creation turn.
• core/dev/smoke.mjs: its first two steps assert silent creation (no kickoff, no waiting, no model call when a model is picked) instead of the greeting this change removes.
• Docs: docs/subsystems/core-host.md, core-client.md and plugin-runtime.md describe silent creation and where a typed line goes; one changelog fragment (changelog.d/645-silent-creation.changed.md).
• patches/ds-bot/ regenerated (four test files got a topics.json entry), core/client.js rebuilt.

What I ran

The previous tip (6ddab1ca) was green in every job except arch-docs, which asked for a subsystem doc for core/dev/smoke.mjs; this tip is the same tree with the Docs-not-needed: trailer above in its commit message.

At this tip, whose parent is main d9f9db07 (main changed nine files since the base a41f8606; none of them is in this diff, so nothing of main's is overwritten):

• core: node --import ./test/harness-resolve.mjs --test --test-concurrency=3 "test/*.test.js" — 1220/1220 pass.
• npm run lint in core: oxlint 0 errors (43 pre-existing warnings) and arch-docs: OK (44 changed file(s)).
• npm run build then node scripts/build-client.mjs --check: client.js matches src/client.
• node scripts/ds-bot-patches.mjs generate then check: ds-bot/ equals the pin (tree 5834c00), 10 patches apply in order, core/ equals ds-bot/ + patches.

Red without the source change

Three separate reverts, each on this tip's tree, each run with the new tests kept:

• Team creation: restored roster.js and groups.js to 9393d558 and ran roster + rounds → 62 tests, 57 pass, 5 fail, and the five are the new cases (the first Main Bot waits for the user to pick a model, and nothing opens a turn, other Bots start on the default model and are sent nothing, creating a Bot sends it nothing, and only a parent Bot's brief becomes its instructions, a group the user makes starts no turn of its own, creating a team starts no turn, and the user's first message opens one round (#645)).
• The INC's path: reverted new-chat.js, create-bot.js, bot-draft.js and roster.js to the 24e7f6da source (the tip the INC was written against) and ran create-bot, new-chat and roster → 38 tests, 35 pass, 3 fail: the payload carries the look and the chosen model, and never a brief (#645), #645: a line typed in the composer is the new Bot's first turn, not its instructions, creating a Bot sends it nothing, and only a parent Bot's brief becomes its instructions.
• Old transcripts: reverted parts.js and ran history → 7 tests, 6 pass, 1 fail (historyEntry keeps answers, user and Bot messages, and skips setup).

The unchanged cases around them (#410 model inheritance, #289, the round and question tests, the handoff and group-chat skips) stay green in all three runs.

Not run

• The bench smoke test (dev/bench.sh smoke): it needs a DSH checkout and a real model route, which this session has no access to. core/dev/smoke.mjs is updated to the new behaviour but was not executed.
• The CI-only jobs package (pack check, typecheck, actionlint) and merge-gate: left to this tip's CI.
• The composer path was pinned by core/test/new-chat.test.js (source assertions on the created flow, the way that file already pins the + menu), not clicked in a browser: one home only here, so the new-Bot card and the sidebar composer were read in the source.

Risk

• User-visible behaviour change by design: a new Bot no longer says hello, and a line typed in the composer now opens the Bot's first turn instead of becoming its instructions. Anything that relied on the greeting (a bot-to-bot dispatch loop that reacted to a Bot's first message) simply starts later, on the first real line.
• One state shape is left behind: a state.json saved by an older version can still carry bot.kickoff (a held greeting). Nothing reads it now, so it is never delivered; it is a few dead bytes per Bot and needs no migration. Say the word and I can strip it on load in a follow-up.
• Scope: core/src/host/**, core/src/client/**, tests, core/dev/smoke.mjs, docs, client.js and regenerated patches/ds-bot/. No change to DSH, no new config key, no permission model change.
• Tier: core/ host behaviour at every team creation — T3.

[Birfy]

Verdict: PASS at 4af1899
Written-by: Reviewer

Ran:

• node --import ./test/harness-resolve.mjs --test "test/*.test.js" (core) → 1052 tests, 1023 pass, 29 fail; the identical 29 fail on base 9393d55 (28 client files need jsdom here, one patch case needs a .git)
• roster.test.js + rounds.test.js with core/src/host/{roster,groups}.js reverted to 9393d55 → 57/62, the five red are the new "nothing opens a turn" cases

Not run:

• a smoke run of the desktop app — not available here

Reviewed at this tip only. All 9 checks are completed/success, mergeable: clean, 0 commits behind main (8e80237b).

Core suite

• This tip: 1052 tests, 1023 pass, 29 fail. The same command on base 9393d558 gives 1056 tests, 1027 pass and the identical 29 failures, file for file: 28 client test files abort with Cannot find module 'jsdom' in this checkout, and one patch case reports cannot diff against HEAD (no .git here). Nothing fails on the tip that passes on base; the 4 fewer tests are the deleted kickoff cases.
• Red without the source change: replacing core/src/host/roster.js and core/src/host/groups.js with their 9393d558 versions on this tree turns roster.test.js + rounds.test.js from 62/62 into 57/62, and the five that go red are exactly the new or rewritten ones ("the first Main Bot … nothing opens a turn", "other Bots … are sent nothing", "creating a Bot sends it nothing …, its brief becomes its instructions", "a group the user makes starts no turn of its own", "#645 creating a team starts no turn"). Reverting channel.js and the client files as well also breaks the view assertions.

What I checked beyond the tests

• No dangling references to what was removed: kickoff, dropKickoff, greetRoom, roomKickoff appear nowhere in core/src, plugins/** or patches/ds-bot/files/**; only docs/subsystems/core-host.md mentions them, to say they are gone. createRoom no longer calls greetRoom, and nothing calls rt.dropKickoff, so removing it from Object.assign(rt, …) breaks no caller.
• core/client.js was regenerated in step with its three sources: the bundle carries exactly the cells.js role test, the two new-chat.js/group-settings.js greet removals, and the text.js comment.
• The model card still opens: ModelChoiceDock decides on bot.model (missing or unserved) and never read the removed waiting flag, so dropping waiting from the roster view changes nothing on screen.
• brief lands in instructions as Why you exist: … only for local Bots (!isRemote), so a friend's Bot is not given instructions the owner did not write; duplicateBot passes the original's instructions and no brief, so the line is copied once and does not accumulate.
• createBot still applies the model for a Bot that has one (waitForModel + applyModel), and a Bot created without one keeps no deferred state at all — no turn is queued anywhere, which is what Team cost controls: per-team activity budget (C) and quiet hours / mute (E) — A and D are shipped #645 asks for.

Non-blocking

• create-room still accepts greet and now ignores it silently (core/src/host/channel.js). A stale client or an out-of-tree plugin that sends greet: true gets success and no opening round, with nothing to tell it the option vanished. Rejecting the flag or documenting it in the channel protocol would make the removal visible.
• A state.json written before this change can still carry a kickoff object on a Bot. Nothing reads it any more, so it is dead data that stays there; harmless, but it will look like a live field to the next reader.

Risk: T3 (core/src/host/{channel,delivery,remote-chat}.js are T3 paths, and the PR also touches patches/**), so it needs a maintainer APPROVED review at this tip next to this PASS. I added awaiting-approval and did not enqueue it.

[Birfy]

Verdict: INC at 24e7f6d
Written-by: Reviewer

The removal itself is clean and I can check it: the kickoff role, [Bot team setup], roomKickoff, greetRoom and round.kickoff are gone from every host path, nothing in core/src reads them any more, create-room simply ignores a greet field an older client still sends, and core/ is generated from ds-bot/ as the package job requires. What blocks it is one path that the issue does not cover: a message the user typed is now swallowed as instructions.

A message the user typed becomes permanent instructions, and gets no answer. In the sidebar a user types in the composer — the box says "Message Bot" — and, when the text is not an existing Bot's name, New Bot "<text>" appears (core/src/client/new-chat.js:186, :200 passes brief: message.trim()). Create then sends it as brief (create-bot.js:43, bot-draft.js:27), and the host folds it into the Bot's instructions (core/src/host/roster.js:100, Why you exist: …) without a turn. So "帮我写周报" typed as a request ends up as a standing instruction the Bot must permanently obey, and the chat opens empty with nothing answering it. Compare the two neighbouring paths, which still do the obvious thing: opening an existing Bot sends the same text (new-chat.js:107), and creating a group sends it after creating the room (new-chat.js:132). #645's proposal A asks that creating a team not speak before the user asks; here the user did ask. The PR deletes the test that pinned exactly this (a first message from the user is helped with, not replaced by an opening question) and replaces it with one that asserts the instruction text.

Fix, either way keeping the rest of the change: after actions.createBot, send the typed line to the new Bot's chat the way openBot and makeGroup do (one user-initiated turn, no kickoff), and keep brief out of the instructions on that path; or keep it in the instructions only for the create_bot tool, where the "brief" is genuinely a parent's context, not something the user typed into a message box expecting an answer.

Ran:

• node --import ./test/harness-resolve.mjs --test --test-timeout=90000 --test-concurrency=6 "test/*.test.js" in core/ at 24e7f6d → 1063 tests, 1034 pass, 29 fail; the same command on main b5de55d → 1067/1038/29, and the two lists of failing files are identical (diff empty: about, client-bundle, check-arch-docs and the rest that need esbuild/git on this machine)
• red without the source change: core/src/host/{roster,groups}.js reverted to the PR's base be0fe17 → roster.test.js + rounds.test.js 62 tests, 57 pass, 5 fail, and the five are exactly the new Team cost controls: per-team activity budget (C) and quiet hours / mute (E) — A and D are shipped #645 cases (the first Main Bot … nothing opens a turn, other Bots … sent nothing, creating a Bot sends it nothing, a group the user makes starts no turn, creating a team starts no turn … #645)
• probe of historyEntry on a kickoff event from an older transcript: {"answer":false,"who":"bot","text":"[Bot team setup]\nhi","keepAnswers":true} — text was '' and keepAnswers false before this PR
• node judge.mjs over this PR's file list → risk-tier: T3; basis: core/src/host/channel.js=T3, …

Not run:

• npm run verify end to end: no esbuild, no git checkout on this machine, so the client-bundle and arch-docs jobs cannot run here; the tip's own tests-ok, package and lint jobs are green
• the two-instance UI walkthrough: one home only, so the new-Bot card path was read in the source and pinned by the tests, not clicked

Non-blocking:

1. parts.js no longer skips source.role === 'kickoff' in historyEntry, so every transcript written before this PR now surfaces its old greeting prompt as the Bot's own text and keeps the answers after it (the probe above). Keeping kickoff in that skip list costs one line and protects existing teams; core/test/history.test.js dropped the assertion that guarded it.
2. core/src/client/text.js still strips the [Bot team setup] header for old lines — the right choice — which makes point 1 the odd one out.
3. core/dev/smoke.mjs:172-181 still asserts the old behaviour (kickoff !== undefined, bots[0].waiting === true, "the greeting is still held"); it fails if anyone runs it.
4. The body says Fixes #645, but Team cost controls: per-team activity budget (C) and quiet hours / mute (E) — A and D are shipped #645 is five proposals and this is A. Closing it here loses B (idle default), C (activity budget) and E (quiet hours); Refs #645 plus separate issues would keep them.

T3: not enqueued, and no approve is wanted while this verdict stands.

[Birfy]

Verdict: PASS at 57d69d4
Written-by: Reviewer

The INC at 24e7f6da is void because the tip moved, and both of its blockers are closed here. A line typed in the composer is no longer a brief: createPayload carries none, new-chat.js hands the card no brief, and created sends the line as one actions.send before the chat opens. roster.js folds a brief into Why you exist: … only when createdBy names a Bot, so create_bot keeps a parent's context and a create-bot request from any client leaves the instructions alone. The old-transcript hiding is back in parts.js (source.role === 'kickoff'), and history.test.js still asserts that the setup prompt stays out while its answers go with it. The PR now says Refs #645 with B/C/E open, so it no longer closes five proposals at once.

Ran: node --import ./test/harness-resolve.mjs --test --test-timeout=90000 --test-concurrency=6 "test/*.test.js" (in core/, TZ=UTC DSH_HARNESS=/opt/flybot)

• tip 57d69d43: 1064 tests, 1035 pass, 29 fail.
• main d9f9db07, same command: 1067 tests, 1038 pass, 29 fail. The two failing sets are identical (diff clean); all 29 are the local esbuild/git misses this machine always has.

Ran: node --import ./test/harness-resolve.mjs --test --test-concurrency=3 test/roster.test.js test/rounds.test.js test/new-chat.test.js test/create-bot.test.js test/history.test.js

• 83 tests, 83 pass, 0 fail.

Ran: GET /repos/ThinkFlowLab/FlyBot/compare/d9f9db07...57d69d4

• 1 commit ahead, 0 behind, 50 files, and the Tip SHA in the body equals the head.

Ran: GET /repos/ThinkFlowLab/FlyBot/commits/57d69d43/check-runs

• 9 checks, all completed/success: tests-ok, merge-gate, package, plugins (social|timeline|tree), ubuntu-latest · Node 24, reviewed tip (report only), risk tier (report only). mergeable: true, mergeable_state: clean.

Ran (red without the source change): copied the tip, restored all 19 source files (core/src/host/*, core/src/client/*, core/client.js, core/dev/smoke.mjs) to d9f9db07, kept every test, same command

• 1064 tests, 1027 pass, 37 fail: eight more than the tip's 29, and all eight are this change's own assertions — #645: a line typed in the composer is the new Bot's first turn, not its instructions, the payload carries the look and the chosen model, and never a brief (#645), creating a Bot sends it nothing, and only a parent Bot's brief becomes its instructions, the first Main Bot waits for the user to pick a model, and nothing opens a turn, other Bots start on the default model and are sent nothing, a group the user makes starts no turn of its own, creating a team starts no turn, and the user's first message opens one round (#645), and the create_bot wording in work-dir.

Not run:

• No browser: the composer path is pinned by new-chat.test.js's source assertions, not clicked in a page.
• scripts/build-client.mjs --check and scripts/ds-bot-patches.mjs check need esbuild/git, neither on this machine; their CI jobs (package) are green at this tip.
• dev/bench.sh smoke needs a real model route.

Not blocking, one line each:

• new-chat.js created: if actions.send rejects, the Bot exists but the card stays open with Create live, so a retry answers A Bot named … already exists and the user is left with a Bot they never see. Closing the card with the error, or opening the chat and showing the failed send there, would leave them somewhere to stand.
• cells.js dropped the source.role === 'kickoff' guard while parts.js kept it, so an old setup line from a Bot-made Bot — hidden in earlier parts — now draws a "Message from " event line in the current part. One line puts the two back in step, and no new kickoff exists that needs the guard gone.
• An older state.json still carries bot.kickoff, and channel.js no longer strips it from the bots view, so that dead object now travels to the client. Nothing reads it, so it is harmless; the follow-up the Risk section offers is a clean place to drop it.