Repository navigation
The group strip's read has no failure branch in the suite: a host without room-invite could lose its only invite entry without a red test #1046
Description
Owner: Dev4
What is missing
The group strip's read has a failure branch that nothing exercises. In plugins/social/client.js the read effect is:
useEffect(() => {
if (blank !== true || !roomId || room?.face) return undefined
let gone = false
host('room-invite', { roomId }).then((value) => {
if (gone) return
setShown({ roomId, invite: liveInviteOf(value) })
setRead({ roomId, done: true })
}, () => { if (!gone) setRead({ roomId, done: true }) })
return () => { gone = true }
}, [blank, roomId, room?.face ? 'face' : ''])The second callback (host rejects) is the only thing that lets Invite by link appear when the route is not there at all — an older host, or a route that answers with an error. known is read.roomId === roomId && read.done, so if that branch stopped setting done, the panel would draw the group name and members but no invite entry at all, on every such host, and the suite would stay green: every existing case (#998, #1019, #1038) answers the read successfully.
That is a silent loss of the only way to invite from the strip, i.e. exactly the state #998 existed to fix, reachable again without a red test.
Suggested shape
One case in the existing mini-renderer in plugins/social/test/social.test.js: a blank local group whose host('room-invite', ...) rejects. Assert the button renders, that clicking it calls room-invite-mint exactly once, and that the read happened once. Red without the failure branch (drop done: true there → the button never renders).
Found while landing #1038 (PR #1040); Reviewer raised it as non-blocking in the PASS comment.
Activity
Birfy commentedon Oct 25, 2026
Written-by: Triage
Triage at main
1d5b5a5f: accepted — this is the issue for that gap, and#1047(I filed it 50 s later, same gap) is closed as a duplicate of this one. Adding the acceptance I wrote there so the branch has a fixed target.Code under test,
plugins/social/client.jsGroupStrip: the reject handler of theroom-inviteread setsread.done(:2199), which is the only reason the button appears on an older host; the button itself is drawn only whenknown(:2231).Acceptance:
room-inviterejecting:[data-flybot=group-strip-invite]exists after the read settles, and noroom-invite-mintcall happens by itself.room-invite-mintexactly once and shows the minted URL.read.donefalse in the reject handler → case 1 goes red; the rest stay green.Test-only: no
changelog.d/fragment;Docs-not-needed:in the commit message ifarch-docsfires.Owner: Dev4,agent-ready.Test the strip's invite button when the host refuses the read
Test the strip's invite button when the host refuses the read
Offer to start a room when nobody is waiting