Skip to content

Implement Huber loss function in Machine Learning loss algorithms. - #697

Merged
vil02 merged 6 commits into
TheAlgorithms:masterfrom
sozelfist:loss/huber
Apr 6, 2024
Merged

vil02 merged 6 commits into
TheAlgorithms:masterfrom
sozelfist:loss/huber

Conversation

@sozelfist

Copy link
Copy Markdown
Contributor

Pull Request Template

Description

This PR implement Huber loss function and add to machine learning loss function module.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I ran bellow commands using the latest version of rust nightly.
  • I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
  • I ran cargo fmt just before my last commit.
  • I ran cargo test just before my last commit and all tests passed.
  • I added my algorithm to the corresponding mod.rs file within its own folder, and in any parent folder(s).
  • I added my algorithm to DIRECTORY.md with the correct link.
  • I checked COUNTRIBUTING.md and my code follows its guidelines.

@sozelfist
sozelfist requested review from imp2002 and vil02 as code owners March 23, 2024 15:36
@codecov-commenter

codecov-commenter commented Mar 23, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.53%. Comparing base (1c6c38d) to head (a77a0bc).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #697   +/-   ##
=======================================
  Coverage   94.53%   94.53%           
=======================================
  Files         294      295    +1     
  Lines       21919    21941   +22     
=======================================
+ Hits        20721    20743   +22     
  Misses       1198     1198           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- `y_true` muse be of same length as `y_pred`
- check `y_pred` emptiness
@sozelfist
sozelfist requested a review from vil02 April 5, 2024 23:52
@vil02
vil02 merged commit 95bf686 into TheAlgorithms:master Apr 6, 2024
@sozelfist
sozelfist deleted the loss/huber branch April 6, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants