Skip to content

Suggestion: Adding Loss functions of Machine Learning in maths folder #559

Closed
Closed
Suggestion: Adding Loss functions of Machine Learning in maths folder#559
Labels
dont-closehelp wanted

Description

@sudo-rsingh
sudo-rsingh
opened on Oct 9, 2023

I would like to suggest adding Loss functions in this repo.

The loss function estimates how well a particular algorithm models the provided data.

Add Loss Functions to: machine_learning/loss_functions

Task List:

  • Cross-Entropy
  • Hinge loss
  • Huber loss.
  • MSE
  • NLL
  • MAE
  • Marginal Ranking
  • KL Divergence

Activity

  1. Navaneeth-Sharma commented on Oct 10, 2023

    @Navaneeth-Sharma
    Navaneeth-Sharma
    on Oct 10, 2023
    Contributor

    Hi @GreatRSingh ,
    Thanks for the suggestion. Just to give an update, Some of them already implemented in maths section. Please check that. I have taken this up to add as many functions as possible.

  2. sudo-rsingh commented on Oct 10, 2023

    @sudo-rsingh
    sudo-rsingh
    on Oct 10, 2023
    ContributorAuthor

    @Navaneeth-Sharma Can you put up a list of loss functions that you are going to implement and which you have already implemented?

  3. Navaneeth-Sharma commented on Oct 10, 2023

    @Navaneeth-Sharma
    Navaneeth-Sharma
    on Oct 10, 2023
    Contributor

    Sorry @GreatRSingh ,
    I think I miss read loss as activation functions. Loss functions aren't implemented. But have a plans to do that specially the basic ones like Cross Entropy, MSE, RMSE. You can take it up some of those, if you like to contribute.

  4. sudo-rsingh commented on Oct 10, 2023

    @sudo-rsingh
    sudo-rsingh
    on Oct 10, 2023
    ContributorAuthor

    @Navaneeth-Sharma ok I will do that.

  5. Navaneeth-Sharma commented on Oct 10, 2023

    @Navaneeth-Sharma
    Navaneeth-Sharma
    on Oct 10, 2023
    Contributor

    Hi, Just an info so that we dont implement the same losses, I will try to take up these loss functions

    • Cross-Entropy loss (bin class, multi class)
    • Hinge loss
    • Huber loss.
      Let me know if any of them are already taken @GreatRSingh

  6. sudo-rsingh commented on Oct 10, 2023

    @sudo-rsingh
    sudo-rsingh
    on Oct 10, 2023
    ContributorAuthor

    @Navaneeth-Sharma No none of them are already taken.

    I will take up MSE, NLL, MAE, MarginRanking, KLDivergence.

  7. sudo-rsingh commented on Oct 11, 2023

    @sudo-rsingh
    sudo-rsingh
    on Oct 11, 2023
    ContributorAuthor

    @Navaneeth-Sharma @siriak I have added a list of Loss Functions in the description.
    Keep Suggesting any other if needed.

  8. github-actions commented on Nov 20, 2023

    @github-actions
    github-actionsBot
    on Nov 20, 2023 – with GitHub Actions

    This issue has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

  9. github-actions
    added
    stale
    on Nov 20, 2023

  10. sudo-rsingh commented on Nov 20, 2023

    @sudo-rsingh
    sudo-rsingh
    on Nov 20, 2023
    ContributorAuthor

    Working on adding Hinge Loss

  11. github-actions
    removed
    stale
    on Nov 21, 2023

  12. github-actions commented on Dec 22, 2023

    @github-actions
    github-actionsBot
    on Dec 22, 2023 – with GitHub Actions

    This issue has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

  13. github-actions
    added
    stale
    on Dec 22, 2023
  14. siriak
    added
    dont-close
    help wanted
    on Dec 22, 2023
  15. github-actions
    removed
    stale
    on Dec 23, 2023

  16. mobley-trent commented on Jan 4, 2024

    @mobley-trent
    mobley-trent
    on Jan 4, 2024
    Contributor

    Are all these functions taken ?

  17. sudo-rsingh commented on Jan 4, 2024

    @sudo-rsingh
    sudo-rsingh
    on Jan 4, 2024 via email
    ContributorAuthor

  18. avats-dev commented on Jan 9, 2024

    @avats-dev
    avats-dev
    on Jan 9, 2024
    Contributor

    Opened a PR to add KL divergence loss as a sub task of this issue. #656
    Kindly review.

  19. sozelfist commented on Mar 23, 2024

    @sozelfist
    sozelfist
    on Mar 23, 2024
    Contributor

    I have opened a PR that implements Huber loss function, which is mentioned is this issue #697 🚀.
    Let's take a look on this PR 🤗.

  20. jkauerl commented on May 29, 2024

    @jkauerl
    jkauerl
    on May 29, 2024
    Contributor

    Are there any function that can still be worked on?

  21. siriak commented on May 29, 2024

    @siriak
    siriak
    on May 29, 2024
    Member

    I think NLL and Marginal Ranking from the list are still not implemented

  22. jkauerl commented on Jun 2, 2024

    @jkauerl
    jkauerl
    on Jun 2, 2024
    Contributor

    Finished implementing both, but have a question regarding the PR. Should I open 2 separate PR's or 1 PR containing both algorithms?

  23. siriak commented on Jun 3, 2024

    @siriak
    siriak
    on Jun 3, 2024
    Member

    2 separate PRs please

  24. sozelfist commented on Jun 3, 2024

    @sozelfist
    sozelfist
    on Jun 3, 2024
    Contributor

    When opening a PR, please make sure that your PR is on a separate branch like feat/ml/loss/nll{marginal_ranking} instead of the master branch (on your fork). This helps the git history clean and avoid accidents when merging the code from the original to your fork repository. Please commit changes with meaningful messages that reflect changes on the source code, not try to make many redundant commits for a single change.

  25. realstealthninja commented on Oct 4, 2024

    @realstealthninja
    realstealthninja
    on Oct 4, 2024
    Contributor

    I would like to suggest adding Loss functions in this repo.

    The loss function estimates how well a particular algorithm models the provided data.

    Add Loss Functions to: machine_learning/loss_functions

    Task List:

    * [x]  Cross-Entropy

* [x]  Hinge loss

* [x]  Huber loss.

* [x]  MSE

* [ ]  NLL

* [x]  MAE

* [ ]  Marginal Ranking

* [x]  KL Divergence

    should probably cross of MR & NLL since that has been implemented in #742 & #734 respectively
    effectively closing this issue?

  26. siriak commented on Oct 5, 2024

    @siriak
    siriak
    on Oct 5, 2024
    Member

    Well done, thank you everybody!

  27. siriak
    closed this as completedon Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    dont-closehelp wanted

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions