Skip to content

fix(mcp): keep tracking validation out of exception reporting - #457

Open
dodeja wants to merge 5 commits into
mainfrom
codex/mcp-sentry-rca-20261018
Open

dodeja wants to merge 5 commits into
mainfrom
codex/mcp-sentry-rca-20261018

Conversation

@dodeja

@dodeja dodeja commented Oct 18, 2026 •

Copy link
Copy Markdown
Member

Why

Handled tracking validation errors currently create generic upstream exceptions in Sentry. This produces alerts when the tool correctly asks for a valid container number or missing tracking input.

What changed

  • Skip exception capture and flush for concrete ContainerCheckDigitError and TrackContainerError instances returned by track_container.
  • Preserve actionable tool text, isError, and operator logs.
  • Keep authentication, timeout, unknown validation, upstream, lookup, and name-spoofed errors captured.

Scope

Addresses the reporting behavior in DEV-13655 and DEV-12452. The existing duplicate-tracking fix in #440 and protocol support in #333 are unchanged. Credential/header scrubbing from #389 is unchanged.

Blast radius

Only the tracking tool's two explicit domain error classes change reporting behavior. This does not alter upstream requests, retries, authorization, or tool schemas.

Verification

  • Real MCP/SDK protocol regressions: 12 failures before the fix; all 42 tracking tests pass after it.
  • Formatting, lint, TypeScript, builds, generation checks, offline protocol smoke, and all offline workspace tests pass, including the Sentry credential-scrubbing pipeline.
  • Full agent-verify remains blocked by the existing main inventory-scanner failure covered by fix(ci): compare advertised MCP tools with the feature map #446: 21 expected tools versus 14 discovered. Reproduced on untouched main; other verifier phases pass separately.

Draft pending resolution of the existing aggregate verification gate. No deployment or issue closure is included.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge.

Summary

Stops reporting two expected tracking error classes to Sentry.

  • Two expected tracking errors no longer go to Sentry.

No actionable issues were found. Tests were not run during this review.

Reviews (1) · Last reviewed commit: "fix(mcp): keep tracking validation out o..." · Reviewed by Greptile

@vercel

vercel Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
api Ready Ready Preview Oct 19, 2026 5:26am UTC

Request Review

@blacksmith-sh

This comment has been minimized.

@dodeja
dodeja marked this pull request as ready for review October 18, 2026 05:32
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T05:27:32.974714Z 236f94a New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added the risk-shadow:high Shadow-only risk signal: high label Oct 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Shadow risk calibration

Signal Result Authority
Path classifier risk:high Deterministic advisory policy
heuristic fallback risk-shadow:high Shadow only

Calibration result: agreement.

Shadow risk never blocks or enables merge. Keep it in observation mode until roughly 50 pull requests have human-reviewed labels, then calibrate before considering any policy use.

@github-actions github-actions Bot added the risk:unknown Advisory evidence unavailable or changed; no merge permission label Oct 19, 2026
@github-actions github-actions Bot added risk:high Advisory path risk; current-head human review needed and removed risk:unknown Advisory evidence unavailable or changed; no merge permission labels Oct 19, 2026
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added risk:unknown Advisory evidence unavailable or changed; no merge permission and removed risk:high Advisory path risk; current-head human review needed labels Oct 19, 2026
@github-actions github-actions Bot added risk:high Advisory path risk; current-head human review needed risk:unknown Advisory evidence unavailable or changed; no merge permission and removed risk:unknown Advisory evidence unavailable or changed; no merge permission risk:high Advisory path risk; current-head human review needed labels Oct 19, 2026
@github-actions github-actions Bot added risk:unknown Advisory evidence unavailable or changed; no merge permission risk:high Advisory path risk; current-head human review needed and removed risk:high Advisory path risk; current-head human review needed risk:unknown Advisory evidence unavailable or changed; no merge permission labels Oct 22, 2026

This branch was successfully deployed

1 active deployment
Preview — 236f94a3 Deployed Oct 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high Advisory path risk; current-head human review needed risk-shadow:high Shadow-only risk signal: high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant