Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Oct 18, 2026
dodeja
marked this pull request as ready for review
October 19, 2026 02:03
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #384's source inventory recognizes
server.registerTool, while its offline protocol smoke accepts any 14 tools containingsearch_docsandwhoami. A registration through an alias can escape the source check, and a same-count substitution can still pass that smoke.Compare the actual
tools/listnames with the existing feature map in the smoke and the existing modern/legacy protocol tests. This removes another hand-maintained count and checks the public inventory regardless of registration syntax. The static implementation-source check remains in place.Stacked on #384. The diff is limited to the protocol smoke and its existing tests.
Validation:
npm run agent-verifypasses all 7 steps, including builds, lint, TypeScript, 52 guard tests, 47 policy tests, 153 CLI tests, 389 SDK tests, 470 MCP tests, generation checks, and offline protocol discovery. The existing live SDK smoke suite remains skipped.EPERM. The unchanged Sentry tests and full gate pass with loopback access. No test settings or credentials were changed.This verifies the exercised tool inventory. It does not establish live API behavior or every runtime configuration.
Need help on this PR? Tag
@codesmith-botwith what you need.Final-head follow-through
Head
a201b1f11389891cc5dbf6d92bb02b89d2412d42was verified again after review inspection. The fullagent-verifygate, MCP coverage test, eval type-check, generated-filter comparison, MCP/API lint, coverage generators, and the six protocol smoke versions all passed locally in the isolated checkout with loopback access. The checkout remains clean.Normal hosted CI did not run because its branch filter excludes this stacked base. The relevant offline CI commands were run locally without changing the workflow or its security settings. This is local verification, not a hosted-CI pass. Authenticated preview/live checks and the Node 20/22 consumer matrix were not run.
The hosted Claude review wrapper reports success, but its log records an authentication failure:
401 OAuth access token is invalid. The actual review is blocked, and no review findings were produced. No credentials were changed and that failed action was not retried. The existing Vercel preview integration and Preview Comments completed successfully; no manual deployment was requested.The PR remains draft and stacked on #384.


Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
The PR checks advertised MCP tool names against
skills/agent-trust/feature-map.jsoninstead of a fixed count.Reviews (1) · Last reviewed commit: "fix(ci): compare advertised MCP tools wi..." · Reviewed by Greptile