fix(mobile): keep the source worktree when starting a thread on a branch - #6
Draft
devin-ai-integration[bot] wants to merge 25 commits into
Draft
devin-ai-integration[bot] wants to merge 25 commits into
devin-ai-integration[bot] wants to merge 25 commits into
Conversation
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
…7861) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
…exists (pingdotgg#12540) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
github-actions
Bot
added
vouch:trusted
The predicate helper and its truth-table tests only restated the guard; the bug lives in effect ordering, which a pure function cannot exercise. Read the draft snapshot inside the effect and explain the race there. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Thread transfer impact
This comment will update automatically after the next completed run. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
On iOS, "New thread on branch" from a worktree thread could open the composer as "New worktree · From origin/main" instead of "Current worktree · ".
Cause: the provider's auto-pick-base-branch effect runs in the same commit as the route writing the thread's branch/worktree into the draft, and its stale view (worktree mode, no branch) overwrote that write.
Fix: the effect checks the draft's live
workspaceSelectionand skips if a branch or non-worktree mode is already set. Fresh worktree drafts still auto-pick a base branch.Why
Repro (iOS, default env mode = worktree): open the + sheet for the project and cancel, then open it for a different project and cancel, then long-press a worktree thread of the first project → New thread on branch. Sheet shows New worktree / From origin/main and sending creates a new worktree. After the fix it shows Current worktree / and the thread lands on the existing worktree.
UI Changes
Verified on the iOS simulator; mobile test/typecheck/lint pass. Not verified on a physical device or Android.
Checklist
Link to Devin session: https://app.devin.ai/sessions/d97ba361e2e1443194895bffb3a59079
Open in Devin Desktop: https://app.devin.ai/desktop/session/d97ba361e2e1443194895bffb3a59079?variant=devin
Requested by: @SunkenInTime