fix: signal coded supervisor skips - #166
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SkyeAv
added this pull request to stack #170
September 15, 2026 17:40
SkyeAv
changed the title
SkyeAv
marked this pull request as ready for review
September 15, 2026 18:07
SkyeAv
force-pushed
the
net/error-code
branch
from
September 15, 2026 18:19
9e1ad3e to
72ce363
Compare
Persist a defensive ConfigRecord.error_code field and expose error_code_of so fleet consumers can distinguish requeueable network failures from deterministic skips without parsing notes. Reset the code at the start of every article attempt so it describes only the latest outcome, while preserving SKIPPED status, legacy notes, metrics, and backward-compatible state loading. Emit one visible supervisor ERROR line for every catch-all skip; bind str(exc) rather than exception objects because loguru's enqueue=True writer silently drops socket-backed HTTPError kwargs during pickling. Document the field, requeue semantics, and mixed-version behavior in the agent guide and changelog. US-005 owns the future llm-transient producer.
SkyeAv
force-pushed
the
net/error-code
branch
from
September 15, 2026 18:41
72ce363 to
cd296c6
Compare
SkyeAv
added a commit
that referenced
this pull request
Sep 15, 2026
Cut 19.0.0 and bump the package version in pyproject.toml, CITATION.cff, and uv.lock. Major: five breaking changes ship. The `tablassert` console command now requires the optional `[cli]` extra, since `cyclopts` and `rich` left the base install (#187). Level-one normalization redefines fullmap keys as cleaned Unicode-lowercase, Porter2-normalized, byte-ordered token sets and moves the database to schema v6, so every schema-v5 fullmap is rejected and must be rebuilt (#171, #172, #174, #175, #176). `build-fullmap --aria2c` is gone -- aria2c is used automatically whenever the `[aria2]` extra is installed (#178) -- and `--taxon-allowlist` is gone because the built-in top-100 experimental-taxon allowlist now applies to every build, guarding both reuse paths by `META.taxon_allowlist` identity (#153). Logging now requires the `[log]` extra and is fully disabled without it (#152). Features: `tablassert.net` is a new stdlib-only transient/permanent classification and retry seam shared by the agent and the BABEL downloader (#163, #164), with one bounded jittered retry layer across the inner agent, reflexion, and judge (#167) and machine-readable `error_code` values on skipped checkpoint records (#166). `build-kg` gained an automatic ephemeral shared-prefix TCode cache keyed by content-addressed XXH64 op digests (#155-#159, #161). The `--distill` corpus became schema-uniform v2 with a sibling `outcomes.ndjson`, a deterministic `RewardConfig`-tunable reward, and the new zero-dependency `tablassert distill-weigh` command (#180-#183). `CLASS_FIELD_OVERRIDES` grants the DAKP sparse qualifier stack on the pinned association classes (#188). Fixes: `distill-export` partitions its corpus by content and unions the schema across record files, so a mixed v1/v2 directory no longer CastErrors or silently stringifies a column (#184); BABEL retry warnings survive the loguru sink; PMC downloads are idempotent, atomic, and bounded-parallel (#165); reflexion and judge prompts are hard-bounded (#168). Changelog: - versioned the Unreleased section as 19.0.0 - 2026-09-15 - merged three duplicate `### Added` blocks into one - moved the two `BREAKING:` entries from `### Changed` into `### Breaking Changes` and added a `**Migration:**` note to all five - added PR links to all 17 entries, which carried none - added the missing entries: the distill v2 corpus/reward/distill-weigh stack (#180-#183), the distill-export schema-drift fix (#184), the TCode run-cache detail (#155-#161), and the README badge removal (#154) Docs: none needed here. Every shipped doc change landed with its own PR, and the docs source-of-truth gate passes against the bumped tree. Testing: - make check -> exit 0 - uv run ruff check . -> All checks passed! - uv run pyright -> 0 errors, 0 warnings, 0 informations - uv run pytest -> 1622 passed, 52 skipped - cargo test --manifest-path rust/Cargo.toml -> 156 passed, 0 failed - cargo clippy --all-targets -- -D warnings -> clean - uv lock --check -> resolved 169 packages, lock current - uv run mkdocs build --strict -> exit 0 - docs SSOT + CLI coverage after the changelog edit -> 204 passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gives every supervisor skip a machine-readable cause so a fleet consumer can requeue the recoverable ones instead of keyword-matching
notes. During the DNS outage burst, 6,008 articles on one worker wereSKIPPEDwith no distinguishing signal beyond prose.Signal
ConfigRecord.error_code: str | None(afterconfig_chars, defensively read in_record_from_dict): the stable kebab-casecodeof the causing exception —network-transient,llm-transient, or any coded error;Nonemeans a deterministic gate or a pre-fieldstate.json.errors.error_code_of(exc)walks__cause__/__context__(≤ 3 links) so library wrappers preserve the code.rec.error_code = None, so a laterMAPPEDcannot retain a stale transient code (the external harness'sclear_article_attemptdoes not clear the field).Visibility
ERRORlog line per catch-all skip, bindingerror=str(exc)— not the exception object, because theenqueue=Truesink silently drops unpicklable kwargs (proven with a socket-backedHTTPError).rec.statusstaysSKIPPEDand theSKIPPED: <error>notes prefix is unchanged for mixed-version consumers.SKIPPEDsites (not-open-access, no-tables, small-table guard) leaveerror_codeuntouched.Testing
uv run pytest tests/test_agent_supervisor.py -q --no-cov -n 0→40 passed;tests/test_agent_storage.py→11 passed(three-attempt persisted-state regression pinning the stale-code fix)enqueue=Truetest with add/remove-by-id sink and athreading.Lock()negative control proving the pickling hazarduv run pytest -q→1565 passed, 15 skipped; ruff/format/pyright clean