Repository navigation
Reject stale-selection suggestion edits - #65
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the exact-main Android release-gate failure after PR #64. Suggestion completion now confirms the live InputConnection has no selected text immediately before any destructive edit, closing the race where onUpdateSelection trails a host-side selection. The check fails closed on unreadable editor state and does not copy or log selection contents. Regression coverage deterministically forces a stale collapsed callback state over a live expanded selection. Validation: Android tools 26/26; JVM tests pass; lint passes; exact regression passes; SuggestionStripTest 18/18 passes. A complete 238-test local run passed the fixed regression and had one separate default-IME readiness fixture failure that had passed in the preceding focused class run. Exact-main CI remains the release gate.