Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An explicitly armed OBS transcription session can now wait without a scheduled cutoff and stop through a session-bound Disarm command. The pipe worker detaches capture on the frontend, drains accepted audio and verifies the terminal receipt without changing the OBS stream. Stopping before capture creates no audio stores; attachment races preserve committed audio, and partial or faulted captures remain incomplete.
The desktop keeps one pipe I/O owner: stop requests signal intent, non-consuming Windows pipe queries keep idle waiting cancellable, and active reads, partial messages and stopping retain finite deadlines. This is development source stacked on #38; it adds no live-capture app entry point or plugin distribution.
Validation: 249 focused desktop tests, all 51 canonical native build/test commands, the 24-command linked plugin build and headless refusal smoke pass. Independent implementation review is clear. Final source/input/output hashes match the local receipts. Live OBS frontend/audio, load and distribution acceptance remain open. The contract and exact commands are in
docs/plans/active/obs-session-disarm.md.All five desktop CI jobs passed at
663d3be: run 34770155972. The release job was skipped.