Conversation
Contributor
Author
|
Closing because this benchmark is based on the obsolete #559 architecture and its checked-in run measured 27/27 exact fallback before the unified ClickHouse path reached main. A fresh mixed differential and 27-query execution matrix must be generated from current main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The ClickHouse SQL and VictoriaMetrics MetricsQL paths need an auditable experiment that keeps all 27 observability queries and every fallback in the denominator. The experiment must reject a benefit claim when a language frontend, published plan, or cross-engine semantic comparison fails.
What
This PR adds a deterministic fixture generator, physical-plan generator, production frontend/compiler auditors, one-command fresh-service runner, structured result comparator, per-query terminal-stage report, and checked-in evidence for one fresh trial with three repetitions.
How
reproduce.pystarts from an empty output directory. It generates the OpenMetrics fixture, Prometheus config and TSDB, and physical plan; records their hashes; builds the data-plane binary from that same clean HEAD; runs the production SQL/MetricsQL frontend and compiler paths; starts fresh Prometheus, VictoriaMetrics, ClickHouse, and data-plane state; randomizes query order with a recorded seed; alternates engine order; and records phase-specific mixed-phase CPU ticks, RSS/HWM, storage, ingest time, lifecycle time, raw responses, and structured comparisons.Before this PR
There was no self-contained way to reproduce the 27-query multi-language measurement. Earlier evidence depended on undeclared
/tmpstate, recorded a stale backend identity, did not structure all protocol comparisons, and overstated the scope of the observed trials.After this PR
One command regenerates the checked evidence without a pre-existing TSDB or fixture. The observed result is deliberately narrow and does not establish acceleration benefit:
exact_fallback; median/p95 5.03/6.34 ms. Native VM: 2.36/9.12 ms.exact_fallback; median/p95 56.25/179.34 ms. Native ClickHouse: 49.92/169.56 ms.oracle_validfor 27/27 mappings.Evidence
tools/o11y-multilang/repro-fresh/manifest.jsonrecords clean source HEAD806945b3, the binary SHA-256, immutable image digests, generated fixture and plan hashes, lifecycle/ingest/query duration, and start/post-ingest/post-query resource snapshots. Raw and structured per-request evidence is checked in alongside it.Verification
python3 -m py_compile tools/o11y-multilang/*.py— passed.rustfmt --edition 2021 --checkover all three benchmark examples — passed.cargo check -p control_plane --exampleswith the shared target directory — passed.reproduce.py --trials 1 --repetitions 3 --seed 20260910from an empty output directory — passed.git diff --checkpassed; generated state directories, logs, TSDB blocks, credentials, and private tokens are absent from the diff.Architectural decisions
The benchmark uses the production language frontends and compiler APIs and leaves PromQL/SDS contracts unchanged. Exact fallback is a terminal measured outcome. Cross-protocol Prometheus/ClickHouse comparison treats labels and values as semantic fields and reports timestamps and result type as non-comparable; native/proxy pairs compare labels, values, timestamps, result type, and warnings.
Limitations and follow-up
This is one fresh trial, so it does not estimate between-trial variance. CPU is process scheduler ticks rather than normalized CPU time, and process totals cover mixed alternating modes, and container writable-layer size is an operational storage proxy. The generated physical plan contains no corpus sidecars: even q03 and q16 pass offline publication validation; their catalog miss is inferred from the sidecar-free measured artifact, while exact fallback is observed on HTTP. Binder, validator, executor, and warm performance are not exercised by the 27-query run. Native histogram exponential interpolation is outside the classic
_bucketq21 query.Human review — do not complete with an agent