Conversation
zzylol
force-pushed
the
review/pr553
branch
from
September 10, 2026 08:05
05cb08d to
700e3cf
Compare
zzylol
force-pushed
the
review/pr553
branch
from
September 10, 2026 08:18
700e3cf to
7d1fd08
Compare
zzylol
marked this pull request as ready for review
September 10, 2026 09:25
3 tasks
Contributor
Author
|
Closing because this branch implements independent MetricsQL/ClickHouse sidecar catalogs that conflict with the unified QueryLanguage + shared QueryPlan DAG now on main. Any remaining MetricsQL behavior must be replayed onto the unified DAG rather than merging this alternate architecture. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
Merged MetricsQL work reused the stable PromQL
QueryPlanEntryidentity/serde contract for non-PromQL queries, and tenant-prefixed VictoriaMetrics routes could consult a global MetricsQL catalog and SummaryStore. ClickHouse publication also needed to remain an independent sidecar while sharing the executable DAG payload.After this PR
QueryPlanEntry { canonical_promql, ... }wire contract and exact lookup behavior.ExecutableQueryPlanpayload while keeping independentMetricsQlPlanCatalogand ClickHouse SQL plan catalogs.ExecutablePlanView; language sidecars never construct a fakeQueryPlanEntryor clone the DAG. Descriptor lookup and readout consume the same borrowed payload.Verification
cargo check --all-targets -q— passed for the full workspace.cargo test -q -p control_plane --lib executable_extraction_preserves_promql_entry_serde— passed; asserts the exact legacy PromQL JSON shape.cargo test -q -p data_plane --lib victoriametrics_instant_and_range_fail_closed_for_each_tenant— passed for tenant-a and tenant-b across instant/range guards.cargo test -q -p data_plane --lib active_metricsql_entry_reaches_the_shared_dag_executor— passed.cargo test -q -p data_plane --lib catalog_install_tests— 6 passed, including invalid ClickHouse sidecar atomicity and invalid MetricsQL pane binding rejection.git diff --check— passed.Final independent verification
clickhouse/clickhouse-server:latest: 1/1 passed.cargo test -p control_plane --lib -q— 712/712 passed on heade0511a05.