Skip to content

feat: install strict backend-local PhysicalPlan profile - #495

Merged
zzylol merged 1 commit into
mainfrom
feat/asapquery-strict-physical-profile
Sep 4, 2026
Merged

zzylol merged 1 commit into
mainfrom
feat/asapquery-strict-physical-profile

Conversation

@zzylol

@zzylol zzylol commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

Stack order

  1. feat(query): compile generic post-ASAP DAG bindings #494 — strict generic QueryPlan DAG compiler/runtime
  2. feat: add backend-local Remote Write foundation #493 — backend-local Prometheus Remote Write foundation
  3. feat: install strict backend-local PhysicalPlan profile #495 (this PR) — strict PhysicalPlan startup/install integration

This PR contains only the strict integration delta over #493.

Scope

This is a physical-plan boot/backend-local ingest phase, not all six compatibility phases. It adds PrometheusRemoteWriteV1 to PrecomputePlan, removes compatibility-profile streaming-config authority, validates a complete JSON PhysicalPlan artifact before startup, reuses validation for staged installs and atomic activation, disables partial config/BackendPlan handles, snapshots one plan per write, scopes deduplication to plan identity/version, gates readiness, and relies on #494 authoritative QueryPlan DAG execution with exact fallback on capability miss.

Verification

  • formatting and data-plane binary check pass
  • data-plane library: 959 passed with one test thread
  • control-plane library: 630 passed
  • binary/profile: 3 passed
  • no ignored Rust E2Es
  • Collector-free HTTP contract posts real Snappy/protobuf Remote Write against an active backend-local plan and verifies 204, counters, readiness, and invalid-encoding rejection

The default parallel suite exposed two pre-existing global-state races; both pass individually and the complete single-threaded suite passes.

Explicit blockers / non-goals

  1. Canonical startup compilation still needs stable serializable QueryWorkload/DataWorkload contracts and a backend-only PhysicalCompiler target; this phase consumes an offline artifact.
  2. A full Remote Write → closed window → QueryPlan warm result → coverage fallback process E2E needs a canonical generated artifact fixture. This PR covers the real Collector-free ingest/readiness boundary; feat(query): compile generic post-ASAP DAG bindings #494 covers bound DAG execution and coverage separately.
  3. Existing exact rate/increase, range-step, and production sketch-result blockers remain out of scope.

This PR does not claim the complete compatibility profile.

@zzylol
zzylol changed the base branch from feat/generic-post-asap-dag-compiler to feat/asapquery-compatibility-profile-runtime September 3, 2026 20:48
@zzylol
zzylol force-pushed the feat/asapquery-compatibility-profile-runtime branch from 83c7a67 to 33ce19e Compare September 4, 2026 03:06
@zzylol
zzylol force-pushed the feat/asapquery-strict-physical-profile branch from 0e373a7 to 80ca19f Compare September 4, 2026 03:07
@zzylol
zzylol force-pushed the feat/asapquery-compatibility-profile-runtime branch from 33ce19e to 4983454 Compare September 4, 2026 03:25
@zzylol
zzylol force-pushed the feat/asapquery-strict-physical-profile branch from 80ca19f to ae117eb Compare September 4, 2026 03:25
@zzylol
zzylol changed the base branch from feat/asapquery-compatibility-profile-runtime to main September 4, 2026 03:43
@zzylol
zzylol merged commit 43fa073 into main Sep 4, 2026
1 check passed
@zzylol
zzylol deleted the feat/asapquery-strict-physical-profile branch September 12, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant