test: add production process E2E tests and manual runner - #478
Merged
Merged
Conversation
This was referenced Sep 3, 2026
Contributor
Author
|
Added production-binary + independent raw-data oracle coverage for every sketch family in commits 2c7a5ed and 2a36b95. Run |
# Conflicts: # data_plane/tests/e2e_modified_otlp_sketch_path.rs
Contributor
Author
|
@milindsrivastava1997 FYI, and this integrate ASAPQuery PR#630 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
./scripts/e2e.sh, with focused component targets; no CI setup is required#[ignore];./scripts/e2e.sh listnow audits all tracked Rust files and fails if an ignore marker returnsHashSetdata_source: asap_query) and validate labels/result valuesCommands
PromQL coverage
quantile_over_time(0.5, metric[10s])quantile_over_time(0.5, metric[10s])No resultregressionquantile_over_time(0.99, metric[10s])quantile_over_time(0.99, metric[30s])quantile_over_time(0.99, metric[3m])count(metric)No resultregressioncount_over_time(metric[10s])topk(3, metric)No result/binding regressionssum(metric)The range endpoint is also tested for invalid
start == endandstep == 0parameters. PR #478 does not claim Prometheus range-step resampling semantics;
that product gap is tracked separately in #487.
Data coverage
[10, 12, 15, 20, 30, 45, 60, 80, 100]1..=10099.01)1..=101, retained belowK=2002,000unique user IDs plus500duplicate observationsHashSetcardinality of2,000gamma=200,alpha=100,delta=75,beta=50gamma,alpha,delta)1..=30,100..=130,1000..=1030service=checkout,service=oracle-e2e, and matrixservice=e2e-testlabelsstart == end,step == 0)The expected values come from raw arrays,
HashSet, orHashMapcalculations.Sketch readout APIs are not used as the oracle; sketch implementations are used
only to produce collector-compatible wire payloads.
Summary / materialization coverage
The terms in this table follow ASAPPlanner's canonical post-ASAP IR. Backend
implementation names such as
Capability::QuantileApproxare not treated as apublic or second logical vocabulary.
SketchAlgorithm::DDSketch+SketchQuery::QuantileSketchAlgorithm::Kll+SketchQuery::QuantileSketchAlgorithm::Hll+SketchQuery::CardinalitySketchAlgorithm::CountSketch+SketchQuery::PointCountcount_over_timereadout diagnosticSketchAlgorithm::Cms+SketchQuery::PointCountSketchAlgorithm::CountSketchWithHeap+SketchQuery::TopKSketchParams, family-specific MessagePack ingest, item labels/counts, and top-k readoutSketchAlgorithm::CmsWithHeap+SketchQuery::TopKSketchParams, MessagePack ingest, item labels/counts, and top-k readoutCoverage means the scenario is present and executable. The strict KLL/HLL/
CountSketch/CMS failures documented below remain product gaps; they are not
reported as passing summary support.
Verification
Passing:
cargo fmt --all -- --checkbash -n scripts/e2e.shgit diff --check./scripts/e2e.sh list: no tracked Rust#[ignore]./scripts/e2e.sh differential: DDSketch production binary + raw median oracle + range endpoint consistency, 1 passed / 0 failed / 0 ignored./scripts/e2e.sh whole, including the production controller -> backend -> OTLP -> SketchStore -> p99 PromQL pathStrict diagnostic result:
./scripts/e2e.sh sketch-oracles: DDSketch passes; production KLL, HLL, CountSketch, and CMS each return ASAP-localNo result for query; 0 ignoredScope notes
systemremains explicit opt-in because it delegates to the sibling ASAPCollector multi-node harness and may build images, start containers, and use SSH.VM_ADDRis provided..worktrees/content is not included.