Skip to content

e2e.sh list misses ignored Rust tests outside data_plane and crates #490

Description

@zzylol

Context

Found while reviewing #478.

./scripts/e2e.sh list prints:

Rust E2E tests marked #[ignore] (expected: none):

but its search roots are limited to:

  • data_plane/tests
  • data_plane/src/tests
  • crates

It does not inspect control_plane/tests, Rust tests embedded elsewhere under control_plane/src, or future Rust packages added at the repository root. The command can therefore report an empty result while a Rust E2E is hidden behind #[ignore].

Location

scripts/e2e.sh, list_suites, around lines 159-166.

Expected

Search every tracked Rust source file while excluding generated/build and private worktree directories, for example using repository-wide rg globs, or enumerate every Rust workspace member and its test roots.

The command should exit non-zero if any forbidden ignored E2E marker is found, rather than only printing matches and returning success.

Done when

A fixture or shell-level test demonstrates that an ignored test under control_plane/tests makes the audit command fail.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions