Skip to content

chore(asap_types): delete dead find_compatible_aggregation #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zzylol merged 1 commit into from
Jul 21, 2026
Merged

chore(asap_types): delete dead find_compatible_aggregation #404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions control_plane/src/sketch_algebra/matcher.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,11 @@
//! on whatever node carries it, not inside the kind — see
//! `crates/asap_types/src/key_by_label_names.rs`'s module doc for the same
//! design call made on the data-plane side), so a two-`Implementation`
//! `Matcher` cannot correctly answer that question. That richer,
//! grouping-aware matching already exists as production code in
//! `asap_types::capability_matching::find_compatible_aggregation`, which
//! checks `AggregationType` compatibility (analogous to `SummaryFamily`
//! here) *and* `grouping_labels` subset-compatibility side by side — the
//! two checks compose at the caller, not inside a single `Matcher::is_satisfied_by`.
//! `Matcher` cannot correctly answer that question. A caller needing that
//! richer, grouping-aware answer must check `AggregationType` compatibility
//! (analogous to `SummaryFamily` here) *and* `grouping_labels`
//! subset-compatibility side by side, composed at the call site rather than
//! inside a single `Matcher::is_satisfied_by`.

use asap_plan::{Implementation, Matcher};
use asap_sketch::SummaryKind;
Expand Down
Loading