chore(asap_types): delete dead find_compatible_aggregation - #404
Merged
Merged
Conversation
…lpers find_compatible_aggregation (capability_matching.rs's largest function, ~1360 lines including its ~30-test module) had zero real callers anywhere in the workspace. Its own StreamingConfig delegate method was also uncalled. TODO.md's own historical note confirms the actual runtime capability-matching path bypasses it entirely. Deleted alongside it: the four helpers it alone called (window_compatible, labels_compatible, spatial_filter_compatible, aggregation_priority), plus is_key_agg_type and is_multi_population_value_type (thin wrappers rustc/grep confirmed had gone unused once their only caller was gone). compatible_agg_types and compatible_storage_backends -- the functions with real production callers -- are untouched. Updated two doc comments (capability_matching.rs's own module doc, control_plane/sketch_algebra/matcher.rs's) that referenced the deleted function as if it were live production code. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
find_compatible_aggregation(capability_matching.rs's largest function) has zero real callers anywhere indata_plane/control_plane— every non-test, non-definition occurrence in the codebase was inside a comment. ItsStreamingConfig::find_compatible_aggregationdelegate was likewise uncalled.TODO.md's own (already-closed) historical note independently confirms the real runtime capability-matching path bypasses this function.window_compatible,labels_compatible,spatial_filter_compatible,aggregation_priority) and its ~30-test module, plusis_key_agg_typeandis_multi_population_value_type(thin wrappers that became unused once their only caller was gone — the former flagged directly byrustc's own dead_code lint).compatible_agg_typesandcompatible_storage_backends— the two functions in this file with real production callers — are untouched.control_plane/src/sketch_algebra/matcher.rs's).Test plan
cargo build --workspace— cleancargo test -p asap_types -p control_plane -p data_plane --no-run— all lib/bin/test/bench targets compilecargo test -p asap_types --lib— 36 passed, 0 failedcargo test -p control_plane --lib— 822 passed, 1 pre-existing unrelated failure (same as confirmed in chore: retire promql_utilities crate, move AggregationType into asap_types #403)rustfmtapplied to touched files only🤖 Generated with Claude Code