Migrate data_plane to the restructured sketchlib API - #334
Merged
Merged
Conversation
asap_sketchlib relocated its portable wire-format sketch DTOs (CountMinSketch, CountSketch, DdSketch, HllSketch, HllVariant, KllSketch, CountMinSketchWithHeap, CmsHeapItem, HydraKllSketch) out from under the `sketches::*` submodules and now re-exports them at the crate root. The MessagePack serde methods also moved onto the MessagePackCodec trait (`to_msgpack` / `from_msgpack`, replacing the old inherent `serialize_msgpack` / `deserialize_msgpack`). Update the sketch accumulators, ingest path, query decoders/reducers, and their tests/benches/examples to the new crate-root paths, import the MessagePackCodec trait where the serde methods are called, and rename the serde calls. Also populate the new sketch-state proto fields (HyperLogLogState.registers_sparse, KllState.offset/value_scale/residuals) at their off-defaults so the emitted wire form is unchanged. Compile-compat only; no wire/serialization or query behavior change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asap_sketchlibrelocated its portable wire-format sketch DTOs (CountMinSketch,CountSketch,DdSketch,HllSketch,HllVariant,KllSketch,CountMinSketchWithHeap,CmsHeapItem,HydraKllSketch) out from under thesketches::*submodules and re-exports them at the crate root. The MessagePack serde methods also moved onto theMessagePackCodectrait (to_msgpack/from_msgpack, replacing the inherentserialize_msgpack/deserialize_msgpack).MessagePackCodectrait where the serde methods are called; renamed the serde calls.HyperLogLogState.registers_sparse,KllState.offset/value_scale/residuals) at off-defaults so the emitted wire form is unchanged.Cross-repo dependency order
Merge last — depends on both upstream PRs:
MessagePackCodecre-export) — Re-export MessagePackCodec at the crate root asap_sketchlib#54asap-precompute-rsmigration — Migrate asap-precompute-rs to the restructured sketchlib API ASAPCollector#435Test plan
cargo check --bin data_planegreencargo check --tests -p data_planegreen (lib tests + all integration tests + benches + examples)🤖 Generated with Claude Code