Migrate asap-precompute-rs to the restructured sketchlib API - #435
Merged
Merged
Conversation
asap_sketchlib moved its portable wire-format sketch DTOs (CountMinSketch, CountSketch, DdSketch, HllSketch, HllVariant) out from under the `sketches::` module and now re-exports them at the crate root, while the `sketches::` module holds the algorithmic sketch types. Update the wrapper imports to the crate-root paths. Also populate the proto fields added to the sketch state messages: HyperLogLogState gains `registers_sparse` (left unset — the wrappers emit the dense register encoding) and KllState gains `offset`/`value_scale`/`residuals` (left at off-defaults — the wrappers emit the raw-f64 item representation). Both keep the existing wire form. Compile-compat only; no wire/serialization behavior change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asap_sketchlibrelocated its portable wire-format sketch DTOs (CountMinSketch,CountSketch,DdSketch,HllSketch,HllVariant) out from under thesketches::module and re-exports them at the crate root; thesketches::module now holds the algorithmic sketch types. Updated the wrapper imports to the crate-root paths.HyperLogLogState.registers_sparse(left unset — wrappers emit the dense register encoding) andKllState.offset/value_scale/residuals(left at off-defaults — wrappers emit the raw-f64 item representation). The emitted wire form is unchanged.Cross-repo dependency order
The asap_sketchlib crate-root
MessagePackCodecre-export (ProjectASAP/asap_sketchlib#54) must merge first. Order:data_planemigrationTest plan
cargo checkgreen forasap-precompute-rscargo testgreen (unit 43, api_surface 11, cross_language_parity 7, runtime 27, 0 failed)🤖 Generated with Claude Code