test(data_plane): gate the KLL byte-parity round-trip test #[ignore] - #237
Merged
Merged
Conversation
`kll_envelope_round_trip_through_backend_adapter` asserted a byte-identical `snapshot → reconstruct_via_runtime → snapshot` round-trip, but that is not achievable in-repo: `reconstruct_via_runtime(KLLSketch, …)` rebuilds the sketch by replaying the envelope's retained `items` through `KLLWrapper::apply_delta` → `update()`. For an input large enough to compact (the test feeds 400 items at k=200 → 2 levels), that re-feed re-compacts the already-compacted item set — lossily, and with a fresh RNG seed (`None`) rather than the original's `Some(42)`. The re-snapshot is a valid KLL summary but not byte-identical. The test's "single-level layout" rationale was simply wrong for this input. KLL's coin state *is* on the wire (`KllState.coin`), but `asap-precompute-rs` has no `KLL::from_wire_state` to consume `levels`/`items`/`coin` directly — `apply_delta` is item-replay only. True byte parity needs that upstream API, tracked in `asap_sketchlib`#41. So this matches the existing pattern for HLL/CS/CMS in this file: `#[ignore]` with a precise reason, gap visible, CI green. The structural round-trip test for KLL stays live. File header updated to move KLL into the "byte parity blocked on upstream" bucket. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pre-existing
kll_envelope_round_trip_through_backend_adapterfailure (flagged in #236) — diagnosed and resolved.Root cause
reconstruct_via_runtime(KLLSketch, …)rebuilds the KLL by replaying the envelope's retaineditemsthroughKLLWrapper::apply_delta→update(). For an input large enough to compact (the test feeds 400 items at k=200 → 2 levels), that re-feed re-compacts the already-compacted set — lossily, and with a fresh RNG seed (None) instead of the original'sSome(42). So the re-snapshot is a valid KLL summary but not byte-identical. The test's "single-level layout" rationale was factually wrong for this input.KLL's coin state is on the wire (
KllState.coin), butasap-precompute-rshas noKLL::from_wire_stateto consumelevels/items/coindirectly —apply_deltais item-replay only. Byte parity needs that upstream API (asap_sketchlib#41).Fix
#[ignore]the byte-parity test with a precise reason — exactly the existing pattern for HLL/CS/CMS in this file. The structural round-trip test for KLL stays live. File header updated.Test plan
cargo test -p data_plane --test edge_runtime_consumes_precompute_rs— 5 pass, 4 ignored, 0 failed (was 1 failed)🤖 Generated with Claude Code