test(data_plane): update asap_tier parity expectations for the ExactAgg routing change - #236
Merged
Merged
Conversation
…gg routing change PR #232 changed `control_plane::asap_tier_analysis`: `rate` / `irate` / `increase` / `sum` and bare selectors now lower to `AggIntent::Sum`, which `capability_for` maps to `Capability::ExactAgg(Sum)` — so they are ASAP-tier-answerable from exact-precompute state instead of being archive-routed. `data_plane` consumes that analyzer, and two of its tests pinned the old behaviour: * `analyzer_parity_18_query_corpus` — the 18-query golden master (PR #188). The `ctrl` rows for q04–q07, q12–q17 (and the q08 label `count_over_time` → `count`) shifted to `OK [... ExactAgg(Sum) ...]` / candidate rows. `GOLDEN` regenerated from the new actual; the `engine` rows — the actual parity contract — are unchanged. * `execute_rejects_bare_selector_via_analyzer` → renamed `execute_bare_selector_falls_over_to_archive`. A bare selector is no longer rejected with `NoCallNodeFound`; it binds to an `ExactAgg(Sum)` candidate that finds no matching policy in the test's DDSketch-only `SketchStore`, so it still `CapabilityMiss`es to the archive engine — same routing outcome, different detail. No behaviour change here — `data_plane`'s test expectations catching up to the intentional #232 analyzer change. 768 lib tests pass. Pre-existing unrelated failure: `kll_envelope_round_trip_through_backend_adapter` (KLL sketch byte serialization) fails on clean `main` too — untouched by this change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR D of the "L1→L5 e2e + wire L4" arc — catches
data_planeup to the #232 analyzer behaviour change. (control_plane's side of #232 already updated its own tests;data_planeconsumes the same analyzer and its suite wasn't run then — my miss.)Why
PR #232 made
control_plane::asap_tier_analysisrouterate/irate/increase/sum/bare-selector toCapability::ExactAgg(Sum)(ASAP-tier-answerable from exact-precompute state) instead of archive.data_plane'sASAPQueryEngineconsumes that analyzer, and two tests pinned the old behaviour.Changes
analyzer_parity_18_query_corpus— the 18-query golden master (PR test(analyzer): α — 18-query parity catalog for analyzer unification #188). RegeneratedGOLDENfrom the new actual: thectrlrows for q04–q07/q12–q17 shifted toOK [... ExactAgg(Sum) ...]/ candidate rows, q08's labelcount_over_time→count. Theenginerows — the actual parity contract — are unchanged.execute_rejects_bare_selector_via_analyzer→ renamedexecute_bare_selector_falls_over_to_archive. A bare selector now binds to anExactAgg(Sum)candidate; with the test's DDSketch-onlySketchStoreit finds no matching policy and stillCapabilityMisses to archive — same routing outcome, different detail string.No behaviour change — just test expectations catching up.
Test plan
cargo build -p data_planecleancargo test -p data_plane --lib— 768 pass, 0 failurescargo test -p control_plane— still 737 passPre-existing unrelated failure:
kll_envelope_round_trip_through_backend_adapter(KLL sketch byte serialization,tests/edge_runtime_consumes_precompute_rs.rs) fails on cleanmaintoo — verified by stashing this change. Not touched here.🤖 Generated with Claude Code