Skip to content

feat(data_plane): wire DualWriteSink into production main #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zzylol merged 1 commit into from
May 13, 2026
Merged

feat(data_plane): wire DualWriteSink into production main #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion data_plane/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ pub use query_engines::{ASAPQueryEngine, InstantVector, QueryResult};
pub use drivers::{HttpServer, HttpServerConfig, OtlpReceiver, OtlpReceiverConfig};

pub use precompute_engine::config::{LateDataPolicy, PrecomputeEngineConfig};
pub use precompute_engine::output_sink::StoreOutputSink;
pub use precompute_engine::output_sink::{DualWriteSink, StoreOutputSink};
pub use precompute_engine::PrecomputeEngine;

pub use utils::read_streaming_config;
Expand Down
14 changes: 11 additions & 3 deletions data_plane/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ use data_plane::precompute_engine::config::LateDataPolicy;
use data_plane::precompute_engine::PrecomputeWorkerDiagnostics;
use data_plane::utils::file_io::read_streaming_config;
use data_plane::{
HttpServer, HttpServerConfig, OtlpReceiver, OtlpReceiverConfig, PrecomputeEngine,
PrecomputeEngineConfig, Result, ASAPQueryEngine, SketchStore, StoreOutputSink,
DualWriteSink, HttpServer, HttpServerConfig, OtlpReceiver, OtlpReceiverConfig,
PrecomputeEngine, PrecomputeEngineConfig, Result, ASAPQueryEngine, SketchStore,
};

#[derive(Parser, Debug)]
Expand Down Expand Up @@ -435,7 +435,15 @@ async fn main() -> Result<()> {
wall_clock_grace_period_ms: 5_000,
schema_persist_path: args.schema_persist_path.clone(),
};
let output_sink = Arc::new(StoreOutputSink::new(store.clone()));
// M2.3.4b — DualWriteSink mirrors precompute writes into the
// legacy SketchStore (still serves queries) AND the new
// SketchIndex (sid-keyed precompute path; query path migration
// is M2.3.5). Replaces StoreOutputSink.
let output_sink = Arc::new(DualWriteSink::new(
store.clone(),
sketch_index.clone(),
hot_reload_config.clone(),
));
let engine = PrecomputeEngine::new(
precompute_config,
hot_reload_config.clone(),
Expand Down