feat(data_plane): wire DualWriteSink into production main - #157
Merged
Merged
Conversation
Phase 5 M2.3.4b — replaces the production `StoreOutputSink` in `main.rs` with `DualWriteSink` (introduced in PR #156). Every precompute the worker emits now lands in BOTH the legacy `SketchStore` (which still serves queries today) AND the new sid-keyed `SketchIndex` via `append_precompute`. The legacy query path is unchanged — SketchIndex is being populated but no consumer reads precompute payloads from it yet. That's M2.3.5. Per-row overhead is one snapshot read + per-row agg-id lookup + sid hash + Box clone, all paid on the worker thread. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 5 M2.3.4b — replaces the production
StoreOutputSinkinmain.rswithDualWriteSink(introduced in PR #156). Every precompute the worker emits now lands in BOTH the legacySketchStoreAND the new sid-keyedSketchIndexviaappend_precompute.The legacy query path is unchanged —
SketchIndexis being populated but no consumer reads precompute payloads from it yet (that's M2.3.5). Per-row overhead: one snapshot read + agg-id lookup + sid hash +Box<dyn AggregateCore>clone, all paid on the worker thread.Test plan
cargo build --bin data_planeclean.cargo check --workspaceclean.🤖 Generated with Claude Code