refactor(workload): separate query demand from data evidence - #442
Merged
Merged
Conversation
Contributor
Author
|
Removed the embedded Current validation: |
zzylol
changed the base branch from
408-promql-instant-aggregates-lose-their-evaluation-horizon-and-lower-directly-over-scan
to
main
September 18, 2026 16:17
zzylol
force-pushed
the
refactor/data-workload-parallel
branch
from
September 18, 2026 16:34
7fbfaf2 to
60d0aea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Query demand and source-data evidence have independent update lifecycles. This PR separates their ownership and passes them as peer inputs through recurrence and lifecycle planning.
Before this PR
QueryWorkloadembedsdata_workload, so updating source evidence requires changing the query-workload object.After this PR
PlanningWorkload { query_workload, data_workload }holds the two independently.QueryWorkloadcontains only language and query demand.WorkloadDemandcarries query demand and optional data evidence together to planning boundaries, with explicit constructors for evidence presence or absence. Shared data validation preserves rejection of invalid ingestion rates and contradictory at-rest evidence.This PR targets
mainand contains only the workload split, caller/test migrations, and its API documentation. Ingestion-interval fields, PromQL lowering, cadence freshness, and Post-ASAP IR handling are in #417, stacked on this PR. Merge this PR first.Validation