Skip to content

refactor: rename L3Scalar to ScalarValue #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zzylol merged 1 commit into from
Aug 18, 2026
Merged

refactor: rename L3Scalar to ScalarValue #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions crates/asap-aware-mapping/src/bind.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ fn lift(schema: &Schema) -> L4Schema {
mod tests {
use super::*;
use asap_types::pre_asap::agg_intent::default_quantile;
use asap_types::pre_asap::expr_ir::{CompareOp, L3Scalar};
use asap_types::pre_asap::expr_ir::{CompareOp, ScalarValue};
use asap_types::pre_asap::query_expr::{Predicate, Source};
use asap_types::pre_asap::schema::{Column, DataType};
use asap_types::types::AccuracyTarget;
Expand Down Expand Up @@ -681,7 +681,7 @@ mod tests {
pred: Predicate(Box::new(QueryExpr::Compare {
left: Box::new(QueryExpr::Column(0)),
op: CompareOp::Gt,
right: Box::new(QueryExpr::Literal(L3Scalar::Float64(0.5))),
right: Box::new(QueryExpr::Literal(ScalarValue::Float64(0.5))),
})),
child: Box::new(agg(vec![], default_quantile(0.99), metric_scan(&[]))),
};
Expand All @@ -693,9 +693,9 @@ mod tests {
fn having_and_multi_intent_stay_logical() {
let mut q = agg(vec![2], default_quantile(0.99), metric_scan(&["job"]));
if let QueryExpr::Aggregate { having, .. } = &mut q {
*having = Some(Predicate(Box::new(QueryExpr::Literal(L3Scalar::Boolean(
true,
)))));
*having = Some(Predicate(Box::new(QueryExpr::Literal(
ScalarValue::Boolean(true),
))));
}
assert!(matches!(
implement_tree(&q).unwrap().expr,
Expand Down
12 changes: 6 additions & 6 deletions crates/frontend-promql/src/promql.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ use asap_types::pre_asap::query_expr::{
AtModifier as L3AtModifier, BinaryOpKind, GroupKeys, GroupSide, L2QueryExpr as L2, Predicate,
Reduction, SortKey, Source, TimeShift, VectorGrouping, VectorMatch, VectorMatchKind,
};
use asap_types::pre_asap::{ArithOp, ColumnRef, CompareOp, InfoMatcher, L3Scalar, SampleKind};
use asap_types::pre_asap::{ArithOp, ColumnRef, CompareOp, InfoMatcher, SampleKind, ScalarValue};
use asap_types::types::AccuracyTarget;

use crate::error::PromqlError as LoweringError;
Expand Down Expand Up @@ -728,7 +728,7 @@ fn walk_histogram_quantiles(call: &Call) -> Result<L2> {
};
Ok(L2::Relabel {
dst: label.clone(),
value: Box::new(L2::Literal(L3Scalar::Utf8(open_metrics_float(phi)))),
value: Box::new(L2::Literal(ScalarValue::Utf8(open_metrics_float(phi)))),
child: Box::new(quantile),
})
})
Expand Down Expand Up @@ -975,8 +975,8 @@ fn walk_label(call: &Call) -> Result<L2> {
name: "label_replace".into(),
args: vec![
L2::Column(ColumnRef::Named(src)),
L2::Literal(L3Scalar::Utf8(regex)),
L2::Literal(L3Scalar::Utf8(replacement)),
L2::Literal(ScalarValue::Utf8(regex)),
L2::Literal(ScalarValue::Utf8(replacement)),
],
};
Ok(L2::Relabel {
Expand All @@ -994,7 +994,7 @@ fn walk_label(call: &Call) -> Result<L2> {
}
let dst = str_arg(call, 1)?;
let sep = str_arg(call, 2)?;
let mut args = vec![L2::Literal(L3Scalar::Utf8(sep))];
let mut args = vec![L2::Literal(ScalarValue::Utf8(sep))];
for i in 3..call.args.args.len() {
args.push(L2::Column(ColumnRef::Named(str_arg(call, i)?)));
}
Expand Down Expand Up @@ -1795,7 +1795,7 @@ fn matcher_to_l3expr(m: &Matcher) -> L2 {
L2::Compare {
left: Box::new(L2::Column(ColumnRef::Named(m.name.clone()))),
op,
right: Box::new(L2::Literal(L3Scalar::Utf8(m.value.clone()))),
right: Box::new(L2::Literal(ScalarValue::Utf8(m.value.clone()))),
}
}

Expand Down
6 changes: 3 additions & 3 deletions crates/frontend-promql/tests/promql_lowering.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
use std::time::Duration;

use asap_types::pre_asap::{
AggIntent, ArithOp, BinaryOpKind, CompareOp, L3Scalar, QueryExpr, Reduction, Source,
AggIntent, ArithOp, BinaryOpKind, CompareOp, QueryExpr, Reduction, ScalarValue, Source,
};
use asap_types::types::AccuracyTarget;
use asap_types::workload::{BatchEntry, Query, QueryLanguage, QueryRequirements, QueryWorkload};
Expand Down Expand Up @@ -50,7 +50,7 @@ fn regex_matcher_lowers_to_regex_compareop() {
// The label matcher's column is resolved positionally against the scan schema.
let path_id = schema.column_id("path").expect("path in scan schema");
assert!(matches!(left.as_ref(), QueryExpr::Column(id) if *id == path_id));
assert!(matches!(right.as_ref(), QueryExpr::Literal(L3Scalar::Utf8(v)) if v == "/api/.*"));
assert!(matches!(right.as_ref(), QueryExpr::Literal(ScalarValue::Utf8(v)) if v == "/api/.*"));
}

// ── *_over_time → Aggregate over TimeRange ──────────────────────────────────────
Expand Down Expand Up @@ -911,7 +911,7 @@ fn quantile_branches(q: &QueryExpr) -> Vec<(String, AggIntent)> {
let QueryExpr::Relabel { value, child, .. } = c else {
panic!("expected Relabel per branch, got {c:?}");
};
let QueryExpr::Literal(L3Scalar::Utf8(v)) = value.as_ref() else {
let QueryExpr::Literal(ScalarValue::Utf8(v)) = value.as_ref() else {
panic!("expected a literal label value, got {value:?}");
};
let QueryExpr::Aggregate { measures, .. } = child.as_ref() else {
Expand Down
8 changes: 4 additions & 4 deletions crates/frontend-sql/src/sql/expr.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use datafusion::logical_expr::{BinaryExpr, Expr, Operator};

use asap_types::pre_asap::{ArithOp, ColumnRef, CompareOp, L3Scalar};
use asap_types::pre_asap::{ArithOp, ColumnRef, CompareOp, ScalarValue};

use crate::error::SqlError as LoweringError;

Expand Down Expand Up @@ -88,11 +88,11 @@ pub(super) fn df_expr_to_l2(expr: &Expr) -> Result<L2, LoweringError> {
Expr::Negative(inner) => {
let inner_l3 = df_expr_to_l2(inner)?;
match inner_l3 {
L2::Literal(L3Scalar::Int64(v)) => Ok(L2::Literal(L3Scalar::Int64(-v))),
L2::Literal(L3Scalar::Float64(v)) => Ok(L2::Literal(L3Scalar::Float64(-v))),
L2::Literal(ScalarValue::Int64(v)) => Ok(L2::Literal(ScalarValue::Int64(-v))),
L2::Literal(ScalarValue::Float64(v)) => Ok(L2::Literal(ScalarValue::Float64(-v))),
other => Ok(L2::Arith {
op: ArithOp::Mul,
left: Box::new(L2::Literal(L3Scalar::Int64(-1))),
left: Box::new(L2::Literal(ScalarValue::Int64(-1))),
right: Box::new(other),
}),
}
Expand Down
24 changes: 13 additions & 11 deletions crates/frontend-sql/src/sql/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ use std::sync::Arc;

use datafusion::catalog_common::MemorySchemaProvider;
use datafusion::common::tree_node::{Transformed, TreeNode, TreeNodeRecursion};
use datafusion::common::{Column as DfColumn, ScalarValue};
use datafusion::common::{Column as DfColumn, ScalarValue as DfScalarValue};
use datafusion::datasource::MemTable;
use datafusion::logical_expr::{
self, Distinct, Expr, JoinType, LogicalPlan, WindowFunctionDefinition,
Expand All @@ -39,7 +39,9 @@ use asap_types::pre_asap::query_expr::{
GroupKeys, L2QueryExpr as L2, Predicate, ProjectItem, Reduction, SortKey, Source,
};
use asap_types::pre_asap::schema::{DataType, Schema};
use asap_types::pre_asap::{ColumnRef, CompareOp, JoinKind, L3Scalar, SetOpKind, WindowFuncKind};
use asap_types::pre_asap::{
ColumnRef, CompareOp, JoinKind, ScalarValue, SetOpKind, WindowFuncKind,
};
use asap_types::types::AccuracyTarget;
use asap_types::workload::SqlDialect;

Expand Down Expand Up @@ -375,7 +377,7 @@ impl<'a> SqlLowerer<'a> {
// unconditional `JOIN` (`lower_join`, below).
let pred = match correlation {
Some(e) => Predicate(Box::new(df_expr_to_l2(&e)?)),
None => Predicate(Box::new(L2::Literal(L3Scalar::Boolean(true)))),
None => Predicate(Box::new(L2::Literal(ScalarValue::Boolean(true)))),
};
Ok(L2::Join {
kind,
Expand Down Expand Up @@ -458,7 +460,7 @@ impl<'a> SqlLowerer<'a> {
}
let pred = Predicate(Box::new(match conjuncts.len() {
// No condition (a CROSS JOIN) is unconditionally true.
0 => L2::Literal(L3Scalar::Boolean(true)),
0 => L2::Literal(ScalarValue::Boolean(true)),
1 => conjuncts.pop().unwrap(),
_ => L2::BoolAnd(conjuncts),
}));
Expand Down Expand Up @@ -498,7 +500,7 @@ impl<'a> SqlLowerer<'a> {
// Nth_value: lift N from the (literal) 2nd arg, keep only the column.
let func = if matches!(func, WindowFuncKind::NthValue(None)) {
let n = match args.get(1) {
Some(L2::Literal(L3Scalar::Int64(n))) if *n > 0 => *n as u64,
Some(L2::Literal(ScalarValue::Int64(n))) if *n > 0 => *n as u64,
other => {
return Err(LoweringError::InvalidExpression(format!(
"NTH_VALUE requires a positive integer literal 2nd arg, got {other:?}"
Expand Down Expand Up @@ -751,7 +753,7 @@ impl<'a> SqlLowerer<'a> {
L2::Column(ColumnRef::Named(name.clone()))
} else {
L2::Cast {
expr: Box::new(L2::Literal(L3Scalar::Null)),
expr: Box::new(L2::Literal(ScalarValue::Null)),
to: dtype.clone(),
try_cast: false,
}
Expand Down Expand Up @@ -1238,8 +1240,8 @@ fn expr_to_group_ref(expr: &Expr) -> Result<ColumnRef, LoweringError> {

fn extract_percentile_q(args: &[Expr]) -> Result<f64, LoweringError> {
let q = match args.get(1) {
Some(Expr::Literal(ScalarValue::Float64(Some(q)))) => *q,
Some(Expr::Literal(ScalarValue::Float32(Some(q)))) => *q as f64,
Some(Expr::Literal(DfScalarValue::Float64(Some(q)))) => *q,
Some(Expr::Literal(DfScalarValue::Float32(Some(q)))) => *q as f64,
_ => {
return Err(LoweringError::InvalidExpression(
"percentile value must be a float literal (2nd arg)".into(),
Expand All @@ -1259,9 +1261,9 @@ fn extract_percentile_q(args: &[Expr]) -> Result<f64, LoweringError> {

fn eval_fetch(expr_opt: &Option<Box<Expr>>) -> Option<usize> {
expr_opt.as_ref().and_then(|e| match e.as_ref() {
Expr::Literal(ScalarValue::Int64(Some(v))) if *v >= 0 => Some(*v as usize),
Expr::Literal(ScalarValue::UInt64(Some(v))) => Some(*v as usize),
Expr::Literal(ScalarValue::Int32(Some(v))) if *v >= 0 => Some(*v as usize),
Expr::Literal(DfScalarValue::Int64(Some(v))) if *v >= 0 => Some(*v as usize),
Expr::Literal(DfScalarValue::UInt64(Some(v))) => Some(*v as usize),
Expr::Literal(DfScalarValue::Int32(Some(v))) if *v >= 0 => Some(*v as usize),
_ => None,
})
}
Expand Down
30 changes: 15 additions & 15 deletions crates/frontend-sql/src/sql/types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ use std::collections::HashMap;
use datafusion::arrow::datatypes::{
DataType as ArrowDataType, Field, Fields, Schema as ArrowSchema,
};
use datafusion::common::ScalarValue;
use datafusion::common::ScalarValue as DfScalarValue;

use asap_types::pre_asap::schema::{Column, DataType, Schema};
use asap_types::pre_asap::L3Scalar;
use asap_types::pre_asap::ScalarValue;

use crate::error::SqlError as LoweringError;

Expand All @@ -37,23 +37,23 @@ impl SqlCatalog {
}
}

pub(super) fn scalar_value_to_l3(sv: &ScalarValue) -> Result<L3Scalar, LoweringError> {
pub(super) fn scalar_value_to_l3(sv: &DfScalarValue) -> Result<ScalarValue, LoweringError> {
match sv {
ScalarValue::Int64(Some(v)) => Ok(L3Scalar::Int64(*v)),
ScalarValue::Int32(Some(v)) => Ok(L3Scalar::Int64(*v as i64)),
ScalarValue::Int16(Some(v)) => Ok(L3Scalar::Int64(*v as i64)),
ScalarValue::Int8(Some(v)) => Ok(L3Scalar::Int64(*v as i64)),
ScalarValue::UInt64(Some(v)) => i64::try_from(*v).map(L3Scalar::Int64).map_err(|_| {
DfScalarValue::Int64(Some(v)) => Ok(ScalarValue::Int64(*v)),
DfScalarValue::Int32(Some(v)) => Ok(ScalarValue::Int64(*v as i64)),
DfScalarValue::Int16(Some(v)) => Ok(ScalarValue::Int64(*v as i64)),
DfScalarValue::Int8(Some(v)) => Ok(ScalarValue::Int64(*v as i64)),
DfScalarValue::UInt64(Some(v)) => i64::try_from(*v).map(ScalarValue::Int64).map_err(|_| {
LoweringError::InvalidExpression(format!("UInt64 value {v} overflows i64"))
}),
ScalarValue::UInt32(Some(v)) => Ok(L3Scalar::Int64(*v as i64)),
ScalarValue::Float64(Some(v)) => Ok(L3Scalar::Float64(*v)),
ScalarValue::Float32(Some(v)) => Ok(L3Scalar::Float64(*v as f64)),
ScalarValue::Utf8(Some(s)) | ScalarValue::LargeUtf8(Some(s)) => {
Ok(L3Scalar::Utf8(s.clone()))
DfScalarValue::UInt32(Some(v)) => Ok(ScalarValue::Int64(*v as i64)),
DfScalarValue::Float64(Some(v)) => Ok(ScalarValue::Float64(*v)),
DfScalarValue::Float32(Some(v)) => Ok(ScalarValue::Float64(*v as f64)),
DfScalarValue::Utf8(Some(s)) | DfScalarValue::LargeUtf8(Some(s)) => {
Ok(ScalarValue::Utf8(s.clone()))
}
ScalarValue::Boolean(Some(b)) => Ok(L3Scalar::Boolean(*b)),
_ if sv.is_null() => Ok(L3Scalar::Null),
DfScalarValue::Boolean(Some(b)) => Ok(ScalarValue::Boolean(*b)),
_ if sv.is_null() => Ok(ScalarValue::Null),
_ => Err(LoweringError::InvalidExpression(format!(
"unsupported scalar: {sv:?}"
))),
Expand Down
4 changes: 2 additions & 2 deletions crates/frontend-sql/tests/sql_lowering.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
use asap_frontend_sql::{lower_sql, SqlCatalog};
use asap_types::pre_asap::schema::{Column, DataType, Schema};
use asap_types::pre_asap::{
AggIntent, CompareOp, GroupKeys, JoinKind, L3Scalar, QueryExpr, Reduction, Source,
AggIntent, CompareOp, GroupKeys, JoinKind, QueryExpr, Reduction, ScalarValue, Source,
WindowFuncKind,
};
use asap_types::types::AccuracyTarget;
Expand Down Expand Up @@ -882,7 +882,7 @@ async fn an_uncorrelated_exists_is_an_unconditional_semi_join() {
let qe = lower("SELECT service FROM metrics WHERE EXISTS (SELECT 1 FROM hosts)").await;
let (kind, pred, _) = join_parts(&qe);
assert_eq!(kind, &JoinKind::Semi);
assert_eq!(*pred, QueryExpr::Literal(L3Scalar::Boolean(true)));
assert_eq!(*pred, QueryExpr::Literal(ScalarValue::Boolean(true)));
}

#[tokio::test]
Expand Down
14 changes: 7 additions & 7 deletions crates/integration-tests/tests/nested.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ use std::time::Duration;
use asap_frontend_promql::lower_promql;
use asap_integration_tests::fixtures::metric_schema;
use asap_types::pre_asap::{
AggIntent, ArithOp, AtModifier, BinaryOpKind, CompareOp, GroupKeys, L3Scalar, Predicate,
QueryExpr, Reduction, Source, TimeShift, VectorMatch, VectorMatchKind,
AggIntent, ArithOp, AtModifier, BinaryOpKind, CompareOp, GroupKeys, Predicate, QueryExpr,
Reduction, ScalarValue, Source, TimeShift, VectorMatch, VectorMatchKind,
};
use asap_types::types::AccuracyTarget;

Expand Down Expand Up @@ -79,7 +79,7 @@ fn q23_sum_by_job_over_filtered_scan() {
predicates: vec![Predicate(Box::new(QueryExpr::Compare {
left: Box::new(QueryExpr::Column(3)),
op: CompareOp::Eq,
right: Box::new(QueryExpr::Literal(L3Scalar::Utf8("200".into()))),
right: Box::new(QueryExpr::Literal(ScalarValue::Utf8("200".into()))),
}))],
schema: metric_schema(&["job", "status"]),
};
Expand All @@ -104,7 +104,7 @@ fn q25_div_over_complex_subtrees() {
predicates: vec![Predicate(Box::new(QueryExpr::Compare {
left: Box::new(QueryExpr::Column(3)),
op: CompareOp::Eq,
right: Box::new(QueryExpr::Literal(L3Scalar::Utf8("200".into()))),
right: Box::new(QueryExpr::Literal(ScalarValue::Utf8("200".into()))),
}))],
schema: metric_schema(&["job", "status"]),
};
Expand Down Expand Up @@ -197,7 +197,7 @@ fn q53_outer_group_key_absent_from_nested_aggregate() {
predicates: vec![Predicate(Box::new(QueryExpr::Compare {
left: Box::new(QueryExpr::Column(3)),
op: CompareOp::Eq,
right: Box::new(QueryExpr::Literal(L3Scalar::Utf8("api-server".into()))),
right: Box::new(QueryExpr::Literal(ScalarValue::Utf8("api-server".into()))),
}))],
schema: metric_schema(&["group", "job"]),
};
Expand Down Expand Up @@ -225,7 +225,7 @@ fn q52_outer_name_label_over_binary_op() {
predicates: vec![Predicate(Box::new(QueryExpr::Compare {
left: Box::new(QueryExpr::Column(2)), // env
op: CompareOp::Eq,
right: Box::new(QueryExpr::Literal(L3Scalar::Utf8(env.into()))),
right: Box::new(QueryExpr::Literal(ScalarValue::Utf8(env.into()))),
}))],
schema: metric_schema(&["env", "__name__"]),
};
Expand Down Expand Up @@ -352,7 +352,7 @@ fn q24_sum_by_job_over_rate_over_filtered_scan() {
predicates: vec![Predicate(Box::new(QueryExpr::Compare {
left: Box::new(QueryExpr::Column(3)),
op: CompareOp::Eq,
right: Box::new(QueryExpr::Literal(L3Scalar::Utf8("200".into()))),
right: Box::new(QueryExpr::Literal(ScalarValue::Utf8("200".into()))),
}))],
schema: metric_schema(&["job", "status"]),
};
Expand Down
10 changes: 5 additions & 5 deletions crates/integration-tests/tests/scan.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

use asap_frontend_promql::lower_promql;
use asap_integration_tests::fixtures::metric_schema;
use asap_types::pre_asap::{CompareOp, L3Scalar, Predicate, QueryExpr, Source};
use asap_types::pre_asap::{CompareOp, Predicate, QueryExpr, ScalarValue, Source};
use asap_types::types::AccuracyTarget;

fn lower(q: &str) -> QueryExpr {
Expand All @@ -29,31 +29,31 @@ fn eq_pred(col_id: usize, value: &str) -> Predicate {
Predicate(Box::new(QueryExpr::Compare {
left: Box::new(QueryExpr::Column(col_id)),
op: CompareOp::Eq,
right: Box::new(QueryExpr::Literal(L3Scalar::Utf8(value.into()))),
right: Box::new(QueryExpr::Literal(ScalarValue::Utf8(value.into()))),
}))
}

fn ne_pred(col_id: usize, value: &str) -> Predicate {
Predicate(Box::new(QueryExpr::Compare {
left: Box::new(QueryExpr::Column(col_id)),
op: CompareOp::Ne,
right: Box::new(QueryExpr::Literal(L3Scalar::Utf8(value.into()))),
right: Box::new(QueryExpr::Literal(ScalarValue::Utf8(value.into()))),
}))
}

fn regex_pred(col_id: usize, pattern: &str) -> Predicate {
Predicate(Box::new(QueryExpr::Compare {
left: Box::new(QueryExpr::Column(col_id)),
op: CompareOp::Regex,
right: Box::new(QueryExpr::Literal(L3Scalar::Utf8(pattern.into()))),
right: Box::new(QueryExpr::Literal(ScalarValue::Utf8(pattern.into()))),
}))
}

fn notregex_pred(col_id: usize, pattern: &str) -> Predicate {
Predicate(Box::new(QueryExpr::Compare {
left: Box::new(QueryExpr::Column(col_id)),
op: CompareOp::NotRegex,
right: Box::new(QueryExpr::Literal(L3Scalar::Utf8(pattern.into()))),
right: Box::new(QueryExpr::Literal(ScalarValue::Utf8(pattern.into()))),
}))
}

Expand Down
4 changes: 2 additions & 2 deletions crates/types/src/dag_export.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ fn build(expr: &QueryExpr, nodes: &mut Vec<DagNode>) -> u32 {
mod tests {
use super::*;
use crate::pre_asap::agg_intent::AggIntent;
use crate::pre_asap::expr_ir::L3Scalar;
use crate::pre_asap::expr_ir::ScalarValue;
use crate::pre_asap::query_expr::{GroupKeys, Predicate, Reduction};
use crate::pre_asap::schema::{Column, DataType, Schema};
use crate::types::AccuracyTarget;
Expand Down Expand Up @@ -430,7 +430,7 @@ mod tests {
#[test]
fn chain_preserves_shape_and_child_links() {
let expr = QueryExpr::Filter {
pred: Predicate(Box::new(QueryExpr::Literal(L3Scalar::Boolean(true)))),
pred: Predicate(Box::new(QueryExpr::Literal(ScalarValue::Boolean(true)))),
child: Box::new(QueryExpr::Aggregate {
reduction: Reduction::Reduce(GroupKeys::none()),
measures: vec![AggIntent::Count {
Expand Down
Loading
Loading