refactor: rename L3Scalar to ScalarValue - #215
Merged
Merged
Conversation
L3Scalar's name was a holdover from the pre-#205 L2Expr/L3Expr split (where the "L2"/"L3" prefix distinguished unresolved-vs-resolved column-reference state); that distinction never applied to the literal type itself, and it no longer means anything now that scalar variants live directly in QueryExpr<C>. ScalarValue says what it is without the stale prefix. Mechanical rename across every crate that names it. One real wrinkle: asap-frontend-sql's sql/mod.rs and sql/types.rs both already import datafusion::common::ScalarValue unqualified — aliased that import to DfScalarValue in both files (matching the file's existing `DataType as ArrowDataType` convention) rather than renaming the asap type, since this crate is asap-types' own vocabulary. Verified: cargo build/clippy(--all-targets --all-features --locked -- -D warnings)/fmt --check/test(--locked)/doc --workspace all clean. Same test counts as before (61+180+68+81+26+0), no doc warnings beyond the pre-existing baseline. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
zzylol
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Renames
L3ScalartoScalarValue(raised during review of #214).L3Scalar's name was a holdover from the pre-#205L2Expr/L3Exprsplit, where the
L2/L3prefix distinguished a scalar expressiontree's unresolved-vs-resolved column-reference state. That distinction
never actually applied to the literal-value type itself (a literal has
no column reference to resolve), and it stopped meaning anything once
#205 folded the scalar variants directly into
QueryExpr<C>.ScalarValuenames what it is without the stale prefix.Wrinkle
asap-frontend-sql'ssql/mod.rsandsql/types.rsboth alreadyimport
datafusion::common::ScalarValueunqualified, so renamingasap_types's type to the same name collided in those two files.Resolved by aliasing the DataFusion import to
DfScalarValuein both(matching the file's existing
DataType as ArrowDataTypeconvention)rather than renaming the
asap-typestype — this crate isasap-types's own vocabulary, DataFusion's is the guest here.Verification
cargo build/clippy --all-targets --all-features --locked -- -D warnings/fmt --all -- --check/test --workspace --locked/doc --workspace --no-depsall clean. Same test counts as before(61 asap-types, 180 asap-frontend-promql, 68 asap-frontend-sql, 81
asap-integration-tests, 26 asap-aware-mapping), no doc warnings beyond
the pre-existing baseline. Pure rename — no behavior change.
🤖 Generated with Claude Code