Skip to content

feat(plan): expose bind::logical for deployment-forced fallback #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zzylol merged 1 commit into from
Jul 22, 2026
Merged

feat(plan): expose bind::logical for deployment-forced fallback #154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions crates/plan/src/bind.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,8 +222,13 @@ fn readout(intent: &AggIntent, col: &ColumnRef) -> SketchQuery {
}

/// Wrap an unrewritten L3 subtree, lifting its schema with every column
/// `L4DataType::Primitive`.
fn logical(expr: &QueryExpr, scope: &BindingScope) -> Result<Rc<L4Node>, ImplementError> {
/// `L4DataType::Primitive`. Public so a deployment can force a node it
/// knows `implement_tree_in_with` would otherwise actively (mis)bind —
/// e.g. an intent this crate's `boundary::implementation_for` maps to an
/// accumulator kind the deployment's runtime doesn't actually implement —
/// through the same fallback this crate's own dispatch uses, without
/// duplicating the schema-lift logic.
pub fn logical(expr: &QueryExpr, scope: &BindingScope) -> Result<Rc<L4Node>, ImplementError> {
let schema = expr.output_schema_in(scope)?;
Ok(Rc::new(L4Node {
expr: SummaryExpr::Logical(Box::new(expr.clone())),
Expand Down
Loading