feat(plan): expose bind::logical for deployment-forced fallback - #154
Merged
Merged
Conversation
A deployment sometimes knows implement_tree_in_with would otherwise actively bind a node to an Implementation it can't actually serve (e.g. an accumulator kind the deployment's runtime doesn't implement yet) -- it needs to force that one node through the same Logical fallback this crate's own dispatch uses, without duplicating the schema-lift plumbing. Widen logical()'s visibility to make that possible. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #146 — that PR merged with only the
size_paramshook commit; this one carries the second commit that was pushed to the same branch afterward but landed after the merge, so it never made it tomain.A deployment sometimes knows
implement_tree_in_withwould otherwise actively bind a node to anImplementationit can't actually serve (e.g. an accumulator kind the deployment's runtime doesn't implement yet) — it needs to force that one node through the sameLogicalfallback this crate's own dispatch uses, without duplicating the schema-lift plumbing. Widensbind::logical's visibility (fn→pub fn) to make that possible.Needed by ASAPQuery-backend#408 (
control_plane's Step B migration ontoasap_sketch::L4Node), which usesasap_plan::bind::logicalto force aCount{Exact}node to stay unbound (that deployment's data plane has noCountaccumulator).Test plan
cargo test -p asap-plan— 26 passed, no change in behavior (pure visibility widening)cargo clippy -p asap-plan --all-targets— clean🤖 Generated with Claude Code